You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (JIRA)" <ji...@apache.org> on 2015/01/01 16:46:13 UTC
[jira] [Updated] (VALIDATOR-336) CUSIPCheckDigit thinks invalid
CUSIP is valid
[ https://issues.apache.org/jira/browse/VALIDATOR-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benedikt Ritter updated VALIDATOR-336:
--------------------------------------
Summary: CUSIPCheckDigit thinks invalid CUSIP is valid (was: CUSIPCheckDigit Thinks Invalid CUSIP is Valid)
> CUSIPCheckDigit thinks invalid CUSIP is valid
> ---------------------------------------------
>
> Key: VALIDATOR-336
> URL: https://issues.apache.org/jira/browse/VALIDATOR-336
> Project: Commons Validator
> Issue Type: Bug
> Reporter: Josh Meyer
> Attachments: CUSIPCheckDigit.java.patch, CusipValidatorTest.java, CusipValidatorTest_v2.java, VALIDATOR-336.patch, cusip.patch
>
>
> When testing if a specific CUSIP is valid using org.apache.commons.validator.routines.checkdigit.CUSIPCheckDigit.CUSIP_CHECK_DIGIT.isValid, a call to this returns true when it should return false. A specific example is with the following invalid CUSIP: DUS0421CW.
> What seems to be happening is when toInt is called on W it turns it to an int value and then sends it to weightedValue. This is fine for the first 8 characters of a CUSIP, but not the check digit. The expected result should be to return false because the check digit is a letter (on a CUSIP a check digit must be 0-9).
> With the current implementation, I believe each CUSIP can have up to 4 valid check digits.
> A test is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)