You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2026/10/20 16:47:27 UTC
[PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
kevinjqliu opened a new pull request, #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493
## Which issue does this PR close?
- Part of #3239.
## What changes are included in this PR?
The wheels statically link ~270 Rust crates but ship no third-party attribution. This adds it with `cargo-about`, as a smaller alternative to #3380.
- `release_python.yml`: sdist and wheel jobs build `bindings/python/LICENSE` as root `LICENSE` + `cargo about` output (`about.toml`, `about.hbs`).
- `bindings/python/LICENSE` is now a placeholder in the repo, `NOTICE` a real file. Both used to be symlinks.
- `bindings/python/NOTICE` has the Arrow, Avro and moka notices. This is hand-maintained, so it can drift when dependencies change.
Not covered yet: `zstd-sys` (vendored zstd C code, BSD-3) and `brotli-decompressor` (MIT half of BSD-3 AND MIT) need clarifications, which I'm leaving for the planned `cargo-about` clarify work. Proc-macro crates are also over-listed (~49 permissive ones, no cargo-about filter).
## Are these changes tested?
Ran the exact `cargo about generate` command locally with a clean `CARGO_HOME`, built a wheel and sdist, and checked `dist-info/licenses/{LICENSE,NOTICE}`. `make check-license-notice` passes. The release workflow itself hasn't run (Windows `>>` redirect, `taiki-e` install of cargo-about), so please check the sdist and wheels from the RC.
## AI Disclosure
Written with Copilot (Claude). Please focus on whether the policy reading is right (Category A/B list in `about.toml`, NOTICE handling) and the known gaps above. Not reviewed by ASF legal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4380338275
##########
bindings/python/about.toml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Configuration for `cargo about`, which lists the license texts of the Rust
+# dependencies compiled into pyiceberg-core.
+#
+# Keep `accepted` in line with deny.toml. Order is preference when a crate offers
+# a choice, so add new licenses at the end.
+#
+# Accepted licenses must be ASF Category A or B:
+# https://www.apache.org/legal/resolved.html
+accepted = [
Review Comment:
yea we can, I'll follow up and make more improvements to the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4331586847
##########
bindings/python/LICENSE:
##########
Review Comment:
Shipping a placeholder `bindings/python/LICENSE` in the repository can lead to non-compliant or confusing artifacts when developers build sdists/wheels outside of the release workflows (e.g., local builds, downstream packagers, forks, or alternative CI). Consider committing a valid `LICENSE` file in-tree (at minimum the Apache 2.0 text, optionally with a clearly marked section for generated third-party licenses), and have the workflow append/replace only the third-party portion. This keeps non-workflow builds correct and improves reliability/compliance.
##########
.github/workflows/release_python.yml:
##########
@@ -125,6 +125,20 @@ jobs:
with:
version: ${{ steps.version.outputs.pep440 }}
+ - name: Install cargo-about
+ uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29 # v2.87.21
+ with:
+ tool: cargo-about@0.9.2
+
+ - name: Generate LICENSE with third-party licenses
+ shell: bash
+ run: |
+ # bindings/python/LICENSE is a placeholder: replace it with the root LICENSE plus bundled dependency licenses.
+ {
+ cat LICENSE
+ cargo about generate -c bindings/python/about.toml --locked --fail --manifest-path bindings/python/Cargo.toml bindings/python/about.hbs
+ } > bindings/python/LICENSE
Review Comment:
This step truncates `bindings/python/LICENSE` before running `cargo about generate`. If `cargo about` fails partway through (e.g., transient IO/cargo resolution issue), the workspace will be left with a partial/empty LICENSE, which can make debugging harder and could affect subsequent steps if the shell behavior changes. Prefer writing to a temporary file and moving it into place only on success (atomic replace), optionally adding an explicit newline/separator between the root LICENSE and the generated section.
##########
bindings/python/about.hbs:
##########
@@ -0,0 +1,63 @@
+{{!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+--}}
+
+--------------------------------------------------------------------------------
+
+This package bundles Rust dependencies. Their licenses follow.
+{{#each licenses}}
+
+--------------------------------------------------------------------------------
+
+{{{name}}}
+
+Used by:
+{{#each used_by}}
+ - {{crate.name}} {{crate.version}}{{#if crate.repository}} ({{crate.repository}}){{/if}}
+{{/each}}
+
+{{{text}}}
+{{/each}}
+
+--------------------------------------------------------------------------------
+
+MIT License
+
+Used by:
+ - brotli-decompressor 5.0.3 (https://github.com/dropbox/rust-brotli-decompressor)
+ (src/context.rs)
Review Comment:
This section hardcodes a specific crate name/version and file path outside the `{{#each licenses}}` loop, so it will become stale when the dependency version changes or is removed. If this is an exception needed due to how `cargo-about` renders license/notice data, prefer encoding it via `about.toml` (e.g., a `clarify` entry keyed to the crate with checksums), or clearly gate/structure the template so the extra block is tied to the actual dependency metadata rather than a fixed version string.
##########
.github/workflows/release_python_nightly.yml:
##########
@@ -61,6 +61,20 @@ jobs:
with:
version: ${{ steps.version.outputs.pep440 }}
+ - name: Install cargo-about
+ uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29 # v2.87.21
+ with:
+ tool: cargo-about@0.9.2
+
+ - name: Generate LICENSE with third-party licenses
+ shell: bash
+ run: |
+ # bindings/python/LICENSE is a placeholder: replace it with the root LICENSE plus bundled dependency licenses.
+ {
+ cat LICENSE
+ cargo about generate -c bindings/python/about.toml --locked --fail --manifest-path bindings/python/Cargo.toml bindings/python/about.hbs
+ } > bindings/python/LICENSE
Review Comment:
The `Install cargo-about` + `Generate LICENSE...` steps are duplicated across multiple jobs and workflows (`release_python.yml` and `release_python_nightly.yml`). Consider factoring this into a composite action (e.g., `.github/actions/generate-third-party-licenses`) or a reusable workflow step to reduce drift and ensure future updates (tool version, args, paths) are applied consistently.
##########
bindings/python/NOTICE:
##########
Review Comment:
The NOTICE header says \"Apache Iceberg Rust\" but this file lives under `bindings/python/` and is presumably intended for the `pyiceberg-core` Python distribution. Consider aligning the product name with the Python package/distribution name (or a more precise label like \"Apache Iceberg (Python bindings)\") to avoid confusion for wheel consumers reading `dist-info` notices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk commented on PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#issuecomment-6359284338
Hi, @kevinjqliu Do you think this is ready for review or you still need some refinement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#issuecomment-6422805149
This PR gets us the correct structure for the LICENSE and NOTICE files, and unblocks 0.11 release. I'll follow up to improve the process and make it easier to maintain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4351549774
##########
.github/actions/generate-python-license/action.yml:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generate wheel third-party licenses
+description: 'Replaces bindings/python/LICENSE and NOTICE with the root files plus the licenses and notices of the Rust dependencies bundled in the wheels. The sdist keeps the root files.'
+runs:
+ using: "composite"
+ steps:
+ - name: Install cargo-about
+ uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29 # v2.87.21
+ with:
+ tool: cargo-about@0.9.2
+
+ - name: Generate LICENSE and NOTICE
+ shell: bash
+ working-directory: bindings/python
+ run: |
+ cargo about generate -c about.toml --locked --fail --manifest-path Cargo.toml about.hbs > third-party-licenses.txt
+ # Both are symlinks to the root files, remove them so the redirects don't write through.
+ rm LICENSE NOTICE
+ cat ../../LICENSE third-party-licenses.txt > LICENSE
+ { cat ../../NOTICE; echo; cat third-party-notices.txt; } > NOTICE
Review Comment:
final NOTICE is root NOTICE + our hand written one in `bindings/python/third-party-notices.txt`
##########
.github/actions/generate-python-license/action.yml:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generate wheel third-party licenses
+description: 'Replaces bindings/python/LICENSE and NOTICE with the root files plus the licenses and notices of the Rust dependencies bundled in the wheels. The sdist keeps the root files.'
+runs:
+ using: "composite"
+ steps:
+ - name: Install cargo-about
+ uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29 # v2.87.21
+ with:
+ tool: cargo-about@0.9.2
+
+ - name: Generate LICENSE and NOTICE
+ shell: bash
+ working-directory: bindings/python
+ run: |
+ cargo about generate -c about.toml --locked --fail --manifest-path Cargo.toml about.hbs > third-party-licenses.txt
+ # Both are symlinks to the root files, remove them so the redirects don't write through.
+ rm LICENSE NOTICE
Review Comment:
both [`bindings/python/LICENSE`](https://github.com/apache/iceberg-rust/blob/ca21f1587c6caaeb88dd3a9e1cc245747e1aba08/bindings/python/LICENSE) and https://github.com/apache/iceberg-rust/blob/ca21f1587c6caaeb88dd3a9e1cc245747e1aba08/bindings/python/NOTICE already exist and symlinks to the root LICENSE/NOTICE.
they are needed by the sdist.
During generation we need to remove them first in order to regenerate these files
##########
bindings/python/third-party-notices.txt:
##########
@@ -0,0 +1,30 @@
+This package bundles the following Rust dependencies that ship their own NOTICE.
Review Comment:
as mentioned in the pr description, this is manually maintained. i checked with my agent a couple of times.
i think this is good enough for now to unblock 0.11 release
##########
.github/workflows/release_python.yml:
##########
@@ -184,6 +185,7 @@ jobs:
uses: $/.github/actions/setup-builder
with:
rust-version: ${{ steps.get-msrv.outputs.msrv }}
+ - uses: $/.github/actions/generate-python-license
Review Comment:
only run when building wheels
##########
.github/actions/generate-python-license/action.yml:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generate wheel third-party licenses
+description: 'Replaces bindings/python/LICENSE and NOTICE with the root files plus the licenses and notices of the Rust dependencies bundled in the wheels. The sdist keeps the root files.'
+runs:
+ using: "composite"
+ steps:
+ - name: Install cargo-about
+ uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29 # v2.87.21
+ with:
+ tool: cargo-about@0.9.2
+
+ - name: Generate LICENSE and NOTICE
+ shell: bash
+ working-directory: bindings/python
+ run: |
+ cargo about generate -c about.toml --locked --fail --manifest-path Cargo.toml about.hbs > cargo-about-output.txt
+ # Both are symlinks to the root files, remove them so the redirects don't write through.
+ rm LICENSE NOTICE
+ cat ../../LICENSE cargo-about-output.txt third-party-licenses.txt > LICENSE
Review Comment:
final LICENSE is root LICENSE + `cargo about` output + manual entries (`third-party-licenses.txt`)
##########
bindings/python/LICENSING.md:
##########
@@ -0,0 +1,72 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# LICENSE and NOTICE for pyiceberg-core
+
+The `pyiceberg-core` wheels are a convenience artifact. We build them and upload them to PyPI as part of every release.
+
+The Rust crates that `pyiceberg-core` depends on are statically linked into each wheel. So the `LICENSE` and `NOTICE` inside a wheel must cover those crates as well as iceberg-rust itself.
+
+The sdist only contains iceberg-rust's own source, so it ships the root `LICENSE` and `NOTICE` unchanged.
+
+## How it works
+
+`LICENSE` and `NOTICE` are generated at build time, before `maturin` builds and packages each wheel.
+
+The [`generate-python-license`](../../.github/actions/generate-python-license/action.yml) action regenerates the wheel's `LICENSE` and `NOTICE` in `bindings/python/`:
+
+- `LICENSE`: the root `LICENSE`, then the [`cargo-about`](https://github.com/EmbarkStudios/cargo-about) output, then the manual entries in `third-party-licenses.txt`.
+- `NOTICE`: the root `NOTICE`, then the manual entries in `third-party-notices.txt`.
+
+The action is used in these workflows:
+
+- [`release_python.yml`](../../.github/workflows/release_python.yml): the release wheels published to PyPI.
+- [`release_python_nightly.yml`](../../.github/workflows/release_python_nightly.yml): the nightly wheels published to TestPyPI.
+- [`bindings_python_ci.yml`](../../.github/workflows/bindings_python_ci.yml): pull requests. It only checks that generation doesn't fail. The generated files are not published.
+
+Note that in the repository, `bindings/python/LICENSE` and `NOTICE` are symlinks to the root files, so builds outside the release workflows ship the plain root files.
+
+## Relevant files
+
+- `about.hbs`: the `cargo-about` output template. Keep it a plain template.
+- `about.toml`: configures `cargo-about`.
+ - `accepted`: the licenses we bundle, matching `deny.toml`. Add new ones at the end, as the order is the preference when a crate offers a choice.
+ - `targets`: the wheel targets. Keep in sync with the build matrices in `release_python.yml` and `release_python_nightly.yml`.
+ - Clarifications, for crates whose license files `cargo-about` can't read (such as `libm`). They pin the file by checksum (`shasum -a 256 <file>`). See the [`cargo-about` docs](https://embarkstudios.github.io/cargo-about/cli/clarify.html).
+- `third-party-licenses.txt`: otherwise, add the license text here. For example, `brotli-decompressor`'s MIT license, which the crate doesn't ship. It names the crate and version, so re-check it when the crate is upgraded.
+- `third-party-notices.txt`: the `NOTICE` entries of dependencies that ship one (Arrow, Avro, moka). Find them from `bindings/python` (the repository's own crates appear too):
+
+ ```shell
+ cargo about generate -c about.toml --locked --fail --manifest-path Cargo.toml --format json \
+ | jq -r '.crates[].package.manifest_path' | xargs -n1 dirname \
+ | xargs -I{} find {} -maxdepth 1 -iname 'NOTICE*'
+ ```
+
+## Keeping entries up to date
Review Comment:
maybe we can automate this, but for now i am happy with the current solution in order to unblock 0.11 release
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -93,6 +93,7 @@ jobs:
with:
key: bindings-python
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
+ - uses: $/.github/actions/generate-python-license
Review Comment:
on PR CI, check if `cargo about` can fail. this gives us a early and clear signal on any dependency changes
##########
bindings/python/LICENSING.md:
##########
Review Comment:
trying to describe most of the changes. I can also leave out this file and just move the content to the PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4367064070
##########
bindings/python/LICENSING.md:
##########
@@ -0,0 +1,72 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# LICENSE and NOTICE for pyiceberg-core
+
+The `pyiceberg-core` wheels are a convenience artifact. We build them and upload them to PyPI as part of every release.
Review Comment:
Does the idea of a 'convenience artifact' come from anywhere in particular?
I see the artifacts as quite critical for any downstream user of PyIceberg, as we should not push the complexity of building on Rust on to them.
(not blocking anything)
##########
bindings/python/third-party-notices.txt:
##########
Review Comment:
I think this is OK.
Doesn't match byte for byte but conveys the original notices intentions. Bits are dropped related to where to find Apache 2.0 license in the source of those crates, for example.
##########
bindings/python/LICENSING.md:
##########
@@ -0,0 +1,72 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# LICENSE and NOTICE for pyiceberg-core
+
+The `pyiceberg-core` wheels are a convenience artifact. We build them and upload them to PyPI as part of every release.
+
+The Rust crates that `pyiceberg-core` depends on are statically linked into each wheel. So the `LICENSE` and `NOTICE` inside a wheel must cover those crates as well as iceberg-rust itself.
+
+The sdist only contains iceberg-rust's own source, so it ships the root `LICENSE` and `NOTICE` unchanged.
+
+## How it works
+
+`LICENSE` and `NOTICE` are generated at build time, before `maturin` builds and packages each wheel.
+
+The [`generate-python-license`](../../.github/actions/generate-python-license/action.yml) action regenerates the wheel's `LICENSE` and `NOTICE` in `bindings/python/`:
+
+- `LICENSE`: the root `LICENSE`, then the [`cargo-about`](https://github.com/EmbarkStudios/cargo-about) output, then the manual entries in `third-party-licenses.txt`.
+- `NOTICE`: the root `NOTICE`, then the manual entries in `third-party-notices.txt`.
+
+The action is used in these workflows:
+
+- [`release_python.yml`](../../.github/workflows/release_python.yml): the release wheels published to PyPI.
+- [`release_python_nightly.yml`](../../.github/workflows/release_python_nightly.yml): the nightly wheels published to TestPyPI.
+- [`bindings_python_ci.yml`](../../.github/workflows/bindings_python_ci.yml): pull requests. It only checks that generation doesn't fail. The generated files are not published.
+
+Note that in the repository, `bindings/python/LICENSE` and `NOTICE` are symlinks to the root files, so builds outside the release workflows ship the plain root files.
+
+## Relevant files
+
+- `about.hbs`: the `cargo-about` output template. Keep it a plain template.
+- `about.toml`: configures `cargo-about`.
+ - `accepted`: the licenses we bundle, matching `deny.toml`. Add new ones at the end, as the order is the preference when a crate offers a choice.
+ - `targets`: the wheel targets. Keep in sync with the build matrices in `release_python.yml` and `release_python_nightly.yml`.
+ - Clarifications, for crates whose license files `cargo-about` can't read (such as `libm`). They pin the file by checksum (`shasum -a 256 <file>`). See the [`cargo-about` docs](https://embarkstudios.github.io/cargo-about/cli/clarify.html).
+- `third-party-licenses.txt`: otherwise, add the license text here. For example, `brotli-decompressor`'s MIT license, which the crate doesn't ship. It names the crate and version, so re-check it when the crate is upgraded.
+- `third-party-notices.txt`: the `NOTICE` entries of dependencies that ship one (Arrow, Avro, moka). Find them from `bindings/python` (the repository's own crates appear too):
+
+ ```shell
+ cargo about generate -c about.toml --locked --fail --manifest-path Cargo.toml --format json \
+ | jq -r '.crates[].package.manifest_path' | xargs -n1 dirname \
+ | xargs -I{} find {} -maxdepth 1 -iname 'NOTICE*'
+ ```
+
+## Keeping entries up to date
+
+Pull request CI runs the action, so it fails when generation fails, for example on a license that isn't in `accepted`.
+
+Everything else needs a manual check and update before every release: the clarifications and `targets` in `about.toml`, `third-party-licenses.txt` and `third-party-notices.txt`. They don't change with the dependencies.
Review Comment:
We need an entry in the release guide for this.
##########
bindings/python/LICENSING.md:
##########
Review Comment:
We do need to keep this this, so we can understand how to maintain these.
##########
bindings/python/LICENSING.md:
##########
@@ -0,0 +1,72 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# LICENSE and NOTICE for pyiceberg-core
+
+The `pyiceberg-core` wheels are a convenience artifact. We build them and upload them to PyPI as part of every release.
+
+The Rust crates that `pyiceberg-core` depends on are statically linked into each wheel. So the `LICENSE` and `NOTICE` inside a wheel must cover those crates as well as iceberg-rust itself.
+
+The sdist only contains iceberg-rust's own source, so it ships the root `LICENSE` and `NOTICE` unchanged.
+
+## How it works
+
+`LICENSE` and `NOTICE` are generated at build time, before `maturin` builds and packages each wheel.
+
+The [`generate-python-license`](../../.github/actions/generate-python-license/action.yml) action regenerates the wheel's `LICENSE` and `NOTICE` in `bindings/python/`:
+
+- `LICENSE`: the root `LICENSE`, then the [`cargo-about`](https://github.com/EmbarkStudios/cargo-about) output, then the manual entries in `third-party-licenses.txt`.
+- `NOTICE`: the root `NOTICE`, then the manual entries in `third-party-notices.txt`.
+
+The action is used in these workflows:
+
+- [`release_python.yml`](../../.github/workflows/release_python.yml): the release wheels published to PyPI.
+- [`release_python_nightly.yml`](../../.github/workflows/release_python_nightly.yml): the nightly wheels published to TestPyPI.
+- [`bindings_python_ci.yml`](../../.github/workflows/bindings_python_ci.yml): pull requests. It only checks that generation doesn't fail. The generated files are not published.
Review Comment:
nitpicky: we can just drop this, it is easy to find and this is easy to grow stale.
##########
.github/actions/generate-python-license/action.yml:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generate wheel third-party licenses
+description: 'Regenerates bindings/python/LICENSE and NOTICE with the root files plus the licenses and notices of the Rust dependencies bundled in the wheels. The sdist keeps the root files.'
+runs:
+ using: "composite"
+ steps:
+ - name: Install cargo-about
+ uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29 # v2.87.21
+ with:
+ tool: cargo-about@0.9.2
+
+ - name: Generate LICENSE and NOTICE
+ shell: bash
+ working-directory: bindings/python
+ run: |
+ cargo about generate -c about.toml --locked --fail --manifest-path Cargo.toml about.hbs > cargo-about-output.txt
+ # Both are symlinks to the root files, remove them so the redirects don't write through.
+ rm LICENSE NOTICE
+ cat ../../LICENSE cargo-about-output.txt third-party-licenses.txt > LICENSE
+ { cat ../../NOTICE; echo; cat third-party-notices.txt; } > NOTICE
Review Comment:
My preference on GHA is to have as much logic as we can in Python scripts, so GHA is a thin orchestration layer installing dependencies and executing individual scripts which can be reproduced locally.
(I don't want to block on this, but I think this is the direction we should head.)
##########
bindings/python/about.toml:
##########
Review Comment:
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#issuecomment-6304301084
cc @dannycjones @CTTY @blackmwk
let me know what you think about this solution. I don't think we need to over index much on LICENSE and NOTICE. Including the dependencies in LICENSE (via `cargo about`) is good enough in my opinion, esp since this is just a connivence artifact. The source distribution's LICENSE is still correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4375765073
##########
bindings/python/about.toml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Configuration for `cargo about`, which lists the license texts of the Rust
+# dependencies compiled into pyiceberg-core.
+#
+# Keep `accepted` in line with deny.toml. Order is preference when a crate offers
+# a choice, so add new licenses at the end.
+#
+# Accepted licenses must be ASF Category A or B:
+# https://www.apache.org/legal/resolved.html
+accepted = [
Review Comment:
nit: Could we have some way to check it's in sync with deny.toml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#issuecomment-6372080620
@blackmwk @dannycjones mind giving this another look?
i iterated on this a bunch, and i think this is the best i can do right now to balance release and maintenance. This can unblock us for now and we can iterate more after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4331426827
##########
bindings/python/about.hbs:
##########
@@ -0,0 +1,63 @@
+{{!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+--}}
+
+--------------------------------------------------------------------------------
+
+This package bundles Rust dependencies. Their licenses follow.
+{{#each licenses}}
+
+--------------------------------------------------------------------------------
+
+{{{name}}}
+
+Used by:
+{{#each used_by}}
+ - {{crate.name}} {{crate.version}}{{#if crate.repository}} ({{crate.repository}}){{/if}}
+{{/each}}
+
+{{{text}}}
+{{/each}}
+
+--------------------------------------------------------------------------------
+
+MIT License
+
+Used by:
+ - brotli-decompressor 5.0.3 (https://github.com/dropbox/rust-brotli-decompressor)
Review Comment:
manual entry for `brotli`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4336491341
##########
bindings/python/about.hbs:
##########
@@ -0,0 +1,63 @@
+{{!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+--}}
+
+--------------------------------------------------------------------------------
+
+This package bundles Rust dependencies. Their licenses follow.
+{{#each licenses}}
+
+--------------------------------------------------------------------------------
+
+{{{name}}}
+
+Used by:
+{{#each used_by}}
+ - {{crate.name}} {{crate.version}}{{#if crate.repository}} ({{crate.repository}}){{/if}}
+{{/each}}
+
+{{{text}}}
+{{/each}}
+
+--------------------------------------------------------------------------------
+
+MIT License
+
+Used by:
+ - brotli-decompressor 5.0.3 (https://github.com/dropbox/rust-brotli-decompressor)
+ (src/context.rs)
+
+Copyright 2013 Google Inc. All Rights Reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
+of the Software, and to permit persons to whom the Software is furnished to do
+so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
Review Comment:
I'm OK with the tradeoff here to say we'll hardcode. I'm hoping that this case is broadly the exception.
##########
bindings/python/LICENSE:
##########
Review Comment:
Agree with Renjie's comment here that this must stand on its own as a valid license file for the source package.
https://github.com/apache/iceberg-rust/pull/3493#pullrequestreview-5598115587
##########
bindings/python/NOTICE:
##########
Review Comment:
It's weird that we're including notices here for dependencies, when we don't distribute their source.
I'm not saying we can't do it, but maybe that we can stage this in another file and copy it into place (perhaps a similar approach for `LICENSE` too)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#issuecomment-6315745444
I missed Renjie's comment on the other PR, sharing here. Renjie shares the concern that the maintenance cost is not worth it, so we should stick to the simpler solution.
https://github.com/apache/iceberg-rust/pull/3414#pullrequestreview-5597975575
I'm OK to move forward with the simpler approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4331419435
##########
.github/workflows/release_python.yml:
##########
@@ -125,6 +125,20 @@ jobs:
with:
version: ${{ steps.version.outputs.pep440 }}
+ - name: Install cargo-about
Review Comment:
the same changes for nightly release pipeline
##########
.github/workflows/release_python.yml:
##########
@@ -125,6 +125,20 @@ jobs:
with:
version: ${{ steps.version.outputs.pep440 }}
+ - name: Install cargo-about
+ uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29 # v2.87.21
+ with:
+ tool: cargo-about@0.9.2
+
+ - name: Generate LICENSE with third-party licenses
+ shell: bash
+ run: |
+ # bindings/python/LICENSE is a placeholder: replace it with the root LICENSE plus bundled dependency licenses.
+ {
+ cat LICENSE
Review Comment:
takes the original [`LICENSE`](https://github.com/apache/iceberg-rust/blob/main/LICENSE) file from repo root and append the `cargo about` output
##########
bindings/python/about.hbs:
##########
@@ -0,0 +1,63 @@
+{{!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+--}}
+
+--------------------------------------------------------------------------------
+
+This package bundles Rust dependencies. Their licenses follow.
+{{#each licenses}}
+
+--------------------------------------------------------------------------------
+
+{{{name}}}
+
+Used by:
+{{#each used_by}}
+ - {{crate.name}} {{crate.version}}{{#if crate.repository}} ({{crate.repository}}){{/if}}
+{{/each}}
+
+{{{text}}}
+{{/each}}
+
+--------------------------------------------------------------------------------
+
+MIT License
+
+Used by:
+ - brotli-decompressor 5.0.3 (https://github.com/dropbox/rust-brotli-decompressor)
Review Comment:
manual entry for `brotli`
##########
bindings/python/about.toml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Configuration for `cargo about`, which lists the license texts of the Rust
+# dependencies compiled into pyiceberg-core.
+#
+# Keep `accepted` in line with deny.toml.
+#
+# Accepted licenses must be ASF Category A or B:
+# https://www.apache.org/legal/resolved.html
+# Unicode-3.0 is not on that page; it is Category A per
+# https://issues.apache.org/jira/browse/LEGAL-660
+accepted = [
+ "Apache-2.0",
+ "BSD-3-Clause",
+ "CC0-1.0",
+ "ISC",
+ "MIT",
+ "Unicode-3.0",
+ "Zlib",
+]
+ignore-build-dependencies = true
+ignore-dev-dependencies = true
+
+# zstd-sys vendors zstd's C code (BSD-3-Clause, Meta) next to the Rust
Review Comment:
`zstd-sys` always compiles zstd's core C library ðŸ˜
but these changes dont look so bad
##########
bindings/python/LICENSE:
##########
Review Comment:
i put a `LICENSE` file here so that its searchable and explains how its actually generated
##########
bindings/python/NOTICE:
##########
Review Comment:
manually added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#issuecomment-6416142789
I think we can try this one again on the merge queue, now that the CI issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): bundle third-party licenses in pyiceberg-core wheels [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4367892454
##########
bindings/python/LICENSING.md:
##########
@@ -0,0 +1,72 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# LICENSE and NOTICE for pyiceberg-core
+
+The `pyiceberg-core` wheels are a convenience artifact. We build them and upload them to PyPI as part of every release.
Review Comment:
when we talk about releases, it generally means the actual source code. In this case, the wheels are "convenience binaries"
https://infra.apache.org/release-distribution.html#release-content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org