[jira] [Commented] (LUCENE-7354) MoreLikeThis incorrectly does toString on Field object

["Grant Ingersoll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348848#comment-15348848 ] 

Grant Ingersoll commented on LUCENE-7354:
-----------------------------------------

In looking at this code, it seems a bit more broken than I first thought.  AFAICT, in retrieveTerms (circa line 79) we loop over the MLT configured fields, then we loop over the filteredDocument entries, but we don't actually check that the values in the filtered document are the ones configured on the MLT object.

> MoreLikeThis incorrectly does toString on Field object
> ------------------------------------------------------
>
>                 Key: LUCENE-7354
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7354
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 6.0.1, 5.5.1, master (7.0)
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>
> In MoreLikeThis.java, circa line 763, when calling addTermFrequencies on a Field object, we are incorrectly calling toString on the Field object, which puts the Field attributes (indexed, stored, et. al) into the String that is returned.
> I'll put up a patch/fix shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org