[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1479: Nacos client enhance

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #1479:
URL: https://github.com/apache/dubbo-go/pull/1479#discussion_r713897597



##########
File path: remoting/nacos/builder.go
##########
@@ -38,94 +36,92 @@ import (
 	"github.com/apache/dubbo-go/config"
 )
 
-// NewNacosConfigClient read the config from url and build an instance
-func NewNacosConfigClient(url *common.URL) (config_client.IConfigClient, error) {
-	nacosConfig, err := getNacosConfig(url)
+// NewNacosConfigClientByUrl read the config from url and build an instance

Review comment:
       NewNacosConfigClientByUrl reads the config from url and builds an instance




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org