You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/09/29 15:37:26 UTC
[GitHub] [couchdb] dch opened a new pull request #3770: align spidermonkey cflags across couch_js settings
dch opened a new pull request #3770:
URL: https://github.com/apache/couchdb/pull/3770
## Overview
Patch fixes couch_js + SM78 compilation on FreeBSD 13.0-RELEASE amd64.
during 3.2.0-rc.1 testing, with FreeBSD SpiderMonkey 78 (which will be only supported SpiderMonkey after the Great Python 2 Deprecation at end of September), following error occurs:
```
Compiled src/couch_changes.erl
Compiling /tmp/couch/3.2.0/rc.1/apache-couchdb-3.2.0/src/couch/priv/couch_js/86/main.cpp
In file included from /tmp/couch/3.2.0/rc.1/apache-couchdb-3.2.0/src/couch/priv/couch_js/86/main.cpp:24:
In file included from /usr/local/include/mozjs-78/jsapi.h:31:
In file included from /usr/local/include/mozjs-78/js/CallArgs.h:74:
/usr/local/include/mozjs-78/js/Value.h:164:55: warning: bitwise operation between different enumeration types ('JSValueTag' and 'JSValueType') is deprecated [-Wdeprecated-enum-enum-conversion]
return static_cast<JSValueTag>(JSVAL_TAG_MAX_DOUBLE | type);
~~~~~~~~~~~~~~~~~~~~ ^ ~~~~
In file included from /tmp/couch/3.2.0/rc.1/apache-couchdb-3.2.0/src/couch/priv/couch_js/86/main.cpp:24:
In file included from /usr/local/include/mozjs-78/jsapi.h:31:
In file included from /usr/local/include/mozjs-78/js/CallArgs.h:73:
In file included from /usr/local/include/mozjs-78/js/RootingAPI.h:24:
/usr/local/include/mozjs-78/js/GCPolicyAPI.h:70:3: error: static_assert failed due to requirement '!std::is_pointer_v<void *>' "Pointer type not allowed for StructGCPolicy"
static_assert(!std::is_pointer_v<T>,
^ ~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/mozjs-78/js/GCPolicyAPI.h:89:26: note: in instantiation of template class 'JS::StructGCPolicy<void *>' requested here
struct GCPolicy : public StructGCPolicy<T> {};
^
/usr/local/include/mozjs-78/js/RootingAPI.h:896:9: note: in instantiation of template class 'JS::GCPolicy<void *>' requested here
JS::GCPolicy<T>::trace(trc, &ptr, name);
^
/usr/local/include/mozjs-78/js/RootingAPI.h:883:8: note: in instantiation of member function 'js::RootedTraceable<void *>::trace' requested here
struct RootedTraceable final : public VirtualTraceable {
^
/usr/local/include/mozjs-78/js/RootingAPI.h:896:20: error: incomplete definition of type 'JS::GCPolicy<void *>'
```
## Testing recommendations
see release test procedure
## Checklist
- [x] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
If this breaks other platforms I can carry it downstream as a local patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #3770: align spidermonkey cflags across couch_js settings
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3770:
URL: https://github.com/apache/couchdb/pull/3770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org