[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on a change in pull request #30: YUNIKORN-489: remove unused message definitions

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #30:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/30#discussion_r553480712



##########
File path: scheduler-interface-spec.md
##########
@@ -910,27 +775,3 @@ message EventRecord {
 }
 ```
 
-### Auto Scaling Metrics
-
-Auto scaling metrics can be monitored and collected by a 3rd party auto-scaler and used as the
-supplementary metrics while making auto-scaling decisions. These metrics are indicating how many
-outstanding resource requests are there in the cluster, due to the shortage of node resources.
-This has excluded requests could not be satisfied because of other reasons, such as hitting queue
-resource limit, user/app limit, desire on certain placement constraints, etc.
-
-```protobuf
-// auto scaling metrics at a certain point of time
-message AutoScalingMetrics {
-  // a list of outstanding requests that desires for additional resources
-  repeated OutstandingResourceRequest outstandingRequests = 1;
-}

Review comment:
       hi @kingamarton  I think we can remove it as it is currently not used by any service.
   We can always track back it won't be a problem when we want to resume the work on this in the future. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org