[jira] [Commented] (OPENNLP-1037) OpenNLP build fails if only the eval tests are run

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995437#comment-15995437 ] 

ASF GitHub Bot commented on OPENNLP-1037:
-----------------------------------------

GitHub user thygesen opened a pull request:

    https://github.com/apache/opennlp/pull/193

    OPENNLP-1037: OpenNLP build fails if only the eval tests are run

    **Modified the surefire configuration:**
    
    "mvn test" will run all tests except those excluded in root pom (*see note)
    "mvn eval" will run all tests and the "SourceForgeModelEval" test.
    
    You can also run specific tests. e.g. "mvn test -DOPENNLP_DATA_DIR=/home/blue/opennlp-data-dir -Dtest=OntoNotes4Pos*"
    
    **Implementations Notes:**
    (Root pom.xml)
    Added  <failIfNoSpecifiedTests>false</failIfNoSpecifiedTests> to global surefire configuration to prevent failure if running specific tests from root folder e.g. mvn test -Dtest=Chunker*
    
    Added profile "eval" which automatically is enabled if OPENNLP_DATA_DIR is defined. e.g. mvn test -DOPENNLP_DATA_DIR=/user/eval-data 
    
    Eval profile: Explicit included tests: "**/*Test.java" and the eval test "**/SourceForgeModelEval.java" which does not follow the normal name pattern and therefore needs to be explicit defined.
    forkCount and failIdNoSpecifiedTests are same as global configuration.
    
    The following tests are disabled. But I cannot figure out why. Can anybody recall why they were disabled?
    /src/test/java/opennlp/tools/stemmer/PorterStemmerTest.java
    /src/test/java/opennlp/tools/stemmer/SnowballStemmerTest.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thygesen/opennlp opennlp-1037

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #193
    
----
commit d44fe15b1bc46639d7ba6b3eb58d8441985ae345
Author: Peter Thygesen <th...@apache.org>
Date:   2017-05-03T18:55:07Z

    OPENNLP-1037: OpenNLP build fails if only the eval tests are run

----


> OpenNLP build fails if only the eval tests are run
> --------------------------------------------------
>
>                 Key: OPENNLP-1037
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1037
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Build, Packaging and Test
>            Reporter: Joern Kottmann
>            Assignee: Peter Thygesen
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> The eval tests usually only run a few selected tests, this results in zero tests run in the opennlp-uima (and other) modules.
> Running zero tests should not fail the build.
> To reproduce this:
> - Go to top level
> - Run some eval tests



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)