[GitHub] incubator-predictionio pull request #283: [PIO-28] Console refactor

[Ziemin <gi...@git.apache.org>]

GitHub user Ziemin opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/283

    [PIO-28] Console refactor

    I moved some logic from functions in console to a separate package - commands. These function should now mostly return Expected[Result] or MaybeError, which are basically aliases for Either[String, Result]. With the introduced changed it will be easier to implement the Admin Server, which could simply make use of the same logic as Console.
    
    In addition to that I removed template get and list commands as well as upgrade, because they are no longer going to be supported. Currently typing one of this commands will result with appropriate error.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ziemin/incubator-predictionio console_refactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #283
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #283: [PIO-28] Console refactor

[vlordier <gi...@git.apache.org>]

Github user vlordier commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/283
  
    then most examples need to be updated to reflect this change, such as 
    http://predictionio.incubator.apache.org/templates/similarproduct/quickstart/ etc
    
    What replaces 
    `pio template list / get ? ` (if anything) ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #283: [PIO-28] Console refactor

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-predictionio/pull/283


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #283: [PIO-28] Console refactor

[dszeto <gi...@git.apache.org>]

Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/283
  
    This looks good to me, but due to the size of this PR, it would be nice to have extra pairs of eyes. Could @pferrel / @EmergentOrder help? This PR would be the first step to making admin API possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---