You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/08 13:32:41 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #22019: Reuse EqualsBuilder in CalculatedResult; Add CalculatedResult unit test
sandynz opened a new pull request, #22019:
URL: https://github.com/apache/shardingsphere/pull/22019
Changes proposed in this pull request:
- Reuse EqualsBuilder in DATA_MATCH impl, reduce new objects creation
- Add CalculatedResult unit test for DATA_MATCH
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o merged pull request #22019: Reuse EqualsBuilder in CalculatedResult; Add CalculatedResult unit test
Posted by GitBox <gi...@apache.org>.
yx9o merged PR #22019:
URL: https://github.com/apache/shardingsphere/pull/22019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22019: Reuse EqualsBuilder in CalculatedResult; Add CalculatedResult unit test
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22019:
URL: https://github.com/apache/shardingsphere/pull/22019#issuecomment-1307282652
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22019?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22019](https://codecov.io/gh/apache/shardingsphere/pull/22019?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a303365) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b2748aa0368b3a80f9522c809217aa3b752a5087?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2748aa) will **increase** coverage by `0.11%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #22019 +/- ##
============================================
+ Coverage 60.86% 60.97% +0.11%
Complexity 2467 2467
============================================
Files 4110 4109 -1
Lines 57253 57199 -54
Branches 9698 9690 -8
============================================
+ Hits 34847 34878 +31
+ Misses 19464 19371 -93
- Partials 2942 2950 +8
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22019?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hm/DataMatchDataConsistencyCalculateAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/22019/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2NoZWNrL2NvbnNpc3RlbmN5L2FsZ29yaXRobS9EYXRhTWF0Y2hEYXRhQ29uc2lzdGVuY3lDYWxjdWxhdGVBbGdvcml0aG0uamF2YQ==) | `37.50% <100.00%> (+25.92%)` | :arrow_up: |
| [...gine/DynamicLoadingSQLParserParameterizedTest.java](https://codecov.io/gh/apache/shardingsphere/pull/22019/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2VuZ2luZS9EeW5hbWljTG9hZGluZ1NRTFBhcnNlclBhcmFtZXRlcml6ZWRUZXN0LmphdmE=) | | |
| [...e/check/consistency/DataConsistencyCheckUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/22019/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2NoZWNrL2NvbnNpc3RlbmN5L0RhdGFDb25zaXN0ZW5jeUNoZWNrVXRpbHMuamF2YQ==) | `66.66% <0.00%> (+33.33%)` | :arrow_up: |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22019/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org