You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by bo...@apache.org on 2008/09/07 23:03:49 UTC

svn commit: r692956 - /myfaces/trinidad/trunk_1.2.x/trinidad-partial-lifecycle/src/main/java/org/apache/myfaces/trinidadinternal/lifecycle/RenderResponseExecutor.java

Author: bommel
Date: Sun Sep  7 14:03:49 2008
New Revision: 692956

URL: http://svn.apache.org/viewvc?rev=692956&view=rev
Log:
(TRINIDAD-1220) Partial Lifecycle for Trinidad

Modified:
    myfaces/trinidad/trunk_1.2.x/trinidad-partial-lifecycle/src/main/java/org/apache/myfaces/trinidadinternal/lifecycle/RenderResponseExecutor.java

Modified: myfaces/trinidad/trunk_1.2.x/trinidad-partial-lifecycle/src/main/java/org/apache/myfaces/trinidadinternal/lifecycle/RenderResponseExecutor.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk_1.2.x/trinidad-partial-lifecycle/src/main/java/org/apache/myfaces/trinidadinternal/lifecycle/RenderResponseExecutor.java?rev=692956&r1=692955&r2=692956&view=diff
==============================================================================
--- myfaces/trinidad/trunk_1.2.x/trinidad-partial-lifecycle/src/main/java/org/apache/myfaces/trinidadinternal/lifecycle/RenderResponseExecutor.java (original)
+++ myfaces/trinidad/trunk_1.2.x/trinidad-partial-lifecycle/src/main/java/org/apache/myfaces/trinidadinternal/lifecycle/RenderResponseExecutor.java Sun Sep  7 14:03:49 2008
@@ -88,6 +88,11 @@
               // add messages to partialTargets
             }
 
+            RenderingContext renderingContext = RenderingContext.getCurrentInstance();
+            // ensure mark PPR active
+            if (PartialPageUtils.isPartialRenderingPass(renderingContext)) {
+              PartialPageUtils.markPPRActive(facesContext);
+            }
             rw.startDocument();
 
             Map<String, String> parameterMap = facesContext.getExternalContext().getRequestParameterMap();
@@ -97,18 +102,15 @@
             // TODO form inside partial Target
             if (form != null)
             {
-              // TODO find a better way
+              // TODO find a better way or should form.encodeBegin called?
               CoreFormData formData = new CoreFormData(formName);
               // FIXME
               formData.addNeededValue(XhtmlConstants.PARTIAL_PARAM);
               formData.addNeededValue(XhtmlConstants.STATE_PARAM);
               formData.addNeededValue(XhtmlConstants.VALUE_PARAM);
-              RenderingContext renderingContext = RenderingContext.getCurrentInstance();
+
               renderingContext.setFormData(formData);
               // FIXME
-              if (PartialPageUtils.isPartialRenderingPass(renderingContext)) {
-                PartialPageUtils.markPPRActive(facesContext);
-              }
               if (renderingContext instanceof CoreRenderingContext)
               {
                 Map<String, String> shortStyles = renderingContext.getSkin().getStyleClassMap(renderingContext);