You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/22 05:35:00 UTC

[GitHub] [spark] gengliangwang commented on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

gengliangwang commented on pull request #31390:
URL: https://github.com/apache/spark/pull/31390#issuecomment-783096639


   As per https://www.postgresql.org/docs/11/functions-binarystring.html, the result type of `btrim` should be of binary type instead of string type.
   @beliefer cloud you fix it? Or, can I revert it first(this PR blocks https://github.com/apache/spark/pull/31349)?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org