You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/14 15:33:33 UTC

[GitHub] [cloudstack] mlsorensen opened a new issue, #6739: VM deletion can fail on volume access revocation if VM's last host is removed

mlsorensen opened a new issue, #6739:
URL: https://github.com/apache/cloudstack/issues/6739

   ##### ISSUE TYPE
    * Bug Report
   
   ##### COMPONENT NAME
   ~~~
   API, Storage
   ~~~
   
   ##### CLOUDSTACK VERSION
   ~~~
   main
   ~~~
   
   ##### CONFIGURATION
   PowerFlex, Datera storage
   
   ##### OS / ENVIRONMENT
   <!--
   Information about the environment if relevant, N/A otherwise
   -->
   
   
   ##### SUMMARY
   If a VM is stopped, then the last host it was running on is removed from cloudstack, the VM can fail to delete. This is because deletion attempts to revoke host access to the VM's volumes and various storage plugins will throw errors if the provided host is null.
   
   Looking through the storage plugin implementations, it looks like this would affect Datera and PowerFlex storage types only.
   
   Generally this seems to be due to passing a null host object to the storage provider's revokeAccess() method. Looked into a holistic fix but there are several places where revokeAccess() can be invoked or could be invoked in the future. Additionally, a storage plugin could choose to handle a null host as a "revoke all" command.
   
   ##### STEPS TO REPRODUCE
   1. Create VM with root on Datera or PowerFlex storage 
   2. Start/stop the VM
   3. remove the host the VM ran on from CloudStack
   4. attempt to delete the VM
   
   ##### EXPECTED RESULTS
   VM should be deleted
   
   
   ##### ACTUAL RESULTS
   Error is thrown during deletion
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mlsorensen commented on issue #6739: VM deletion can fail on volume access revocation if VM's last host is removed

Posted by GitBox <gi...@apache.org>.
mlsorensen commented on issue #6739:
URL: https://github.com/apache/cloudstack/issues/6739#issuecomment-1248524150

   @sharmadhiraj86 that would be great. I don't have access to assign.
   
   Looking at the SolidFire implementation, they seem to not be affected.  I have a PowerFlex fix already that I've tested.
   
   I do think it might be worth looking at everywhere that we call revokeAccess and figure out if we really do want to even call revoke if the host is null, but at a minimum making sure the managed storage plugins are handling it seems necessary to avoid further issues long term.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sharmadhiraj86 commented on issue #6739: VM deletion can fail on volume access revocation if VM's last host is removed

Posted by GitBox <gi...@apache.org>.
sharmadhiraj86 commented on issue #6739:
URL: https://github.com/apache/cloudstack/issues/6739#issuecomment-1247613959

   Hey, I want to work on this issue, can you assign this issue to me please? @rohityadavcloud @mlsorensen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on issue #6739: VM deletion can fail on volume access revocation if VM's last host is removed

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on issue #6739:
URL: https://github.com/apache/cloudstack/issues/6739#issuecomment-1272193935

   Closing this as main reported issue fir powerflex has been fixed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud closed issue #6739: VM deletion can fail on volume access revocation if VM's last host is removed

Posted by GitBox <gi...@apache.org>.
rohityadavcloud closed issue #6739: VM deletion can fail on volume access revocation if VM's last host is removed
URL: https://github.com/apache/cloudstack/issues/6739


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org