You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/17 01:50:26 UTC

[I] [Studio][Performance] Page DLQ group discovery before loading runtime stats [rocketmq-dashboard]

Aias00 opened a new issue, #2281:
URL: https://github.com/apache/rocketmq-dashboard/issues/2281

   ## Problem
   The DLQ list fetches all topics, identifies every DLQ topic, then calls `examineTopicStats` for every discovered group before returning an unbounded list. A cluster with many DLQ groups turns one page load into N+1 Admin RPCs.
   
   ## Scope
   - add bounded page/pageSize parameters and a `PageResult<DLQGroupVO>` response
   - sort DLQ topic/group identities deterministically and page them before per-topic stats lookups
   - update API, service, UI, and regression tests
   
   ## Out of scope
   - DLQ resend semantics and message scans
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Performance] Page DLQ group discovery before loading runtime stats [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.

RockteMQ-AI commented on issue #2281:
URL: https://github.com/apache/rocketmq-dashboard/issues/2281#issuecomment-5311300425

**Issue Evaluation**

Category: `enhancement` | Status: **Evaluated**

**Feasibility:** Feasible
**Scope:** DLQ group listing API (likely `DLQController` or `DeadLetterQueueService`)
**Compatibility:** API change (adds pagination parameters); requires UI update

This addresses a classic N+1 query problem in the DLQ discovery path. The current implementation fetches all topics, filters DLQs, then calls `examineTopicStats` for each one before returning an unbounded list.

**Assessment:**
- The problem is valid: large clusters with many DLQ groups will cause excessive Admin RPCs
- The proposed solution (pagination + deterministic sorting + bounded stats lookups) is the correct approach
- Clear scope definition (excludes DLQ resend semantics) helps focus the implementation

**Recommendation:** Proceed with implementation. Consider:
1. Default page size should be reasonable (e.g., 20-50) to avoid overwhelming the UI
2. Sorting should be by DLQ group name for consistency
3. The `PageResult<DLQGroupVO>` response should include total count for UI pagination controls
4. Update both API and UI in the same PR to maintain consistency

---
*Automated evaluation by RockteMQ-AI*

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Performance] Page DLQ group discovery before loading runtime stats [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on issue #2281:
URL: https://github.com/apache/rocketmq-dashboard/issues/2281#issuecomment-5447732331

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Performance] Page DLQ group discovery before loading runtime stats [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed issue #2281: [Studio][Performance] Page DLQ group discovery before loading runtime stats
URL: https://github.com/apache/rocketmq-dashboard/issues/2281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Performance] Page DLQ group discovery before loading runtime stats [rocketmq-dashboard]

Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.

tju-yxq commented on issue #2281:
URL: https://github.com/apache/rocketmq-dashboard/issues/2281#issuecomment-5352564017

   #2282 was superseded by #2308, and the relevant DLQ behavior was included in merged #2365 (22c26d25). Current RocketMQDLQProvider already returns a PageResult<DLQGroupVO>, so this issue is already implemented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org