You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ta...@apache.org on 2020/09/23 16:23:20 UTC

[incubator-superset] branch master updated: fix: menu shows a 0 when there are not settings (#11009)

This is an automated email from the ASF dual-hosted git repository.

tai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 345fe07  fix: menu shows a 0 when there are not settings (#11009)
345fe07 is described below

commit 345fe07d6416f9f51a7ff061a627600c4b128d84
Author: ʈᵃᵢ <td...@gmail.com>
AuthorDate: Wed Sep 23 09:22:45 2020 -0700

    fix: menu shows a 0 when there are not settings (#11009)
---
 superset-frontend/src/components/Menu/Menu.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/components/Menu/Menu.tsx b/superset-frontend/src/components/Menu/Menu.tsx
index 73f6d8d..126b41c 100644
--- a/superset-frontend/src/components/Menu/Menu.tsx
+++ b/superset-frontend/src/components/Menu/Menu.tsx
@@ -187,7 +187,7 @@ export function Menu({
         </Nav>
         <Nav className="navbar-right">
           {!navbarRight.user_is_anonymous && <NewMenu />}
-          {settings && settings.length && (
+          {settings && settings.length > 0 && (
             <NavDropdown id="settings-dropdown" title="Settings">
               {flatSettings.map((section, index) => {
                 if (section === '-') {