You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dave Robinson (JIRA)" <de...@myfaces.apache.org> on 2010/01/25 20:55:34 UTC
[jira] Created: (TRINIDAD-1696) acc (screen reader mode) layout
tables should include role="presentation"
acc (screen reader mode) layout tables should include role="presentation"
-------------------------------------------------------------------------
Key: TRINIDAD-1696
URL: https://issues.apache.org/jira/browse/TRINIDAD-1696
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 1.2.12-core
Environment: all
Reporter: Dave Robinson
Priority: Minor
When using trh:tableLayout in our page to layout some UI components, it gives
warning during Accessibility testing:
"WARNING - This layout Table could be confused for a data table by Screen
Readers"
>From the html perspective, this warning can be fixed by setting
role="presentation"
on the html table element.
We can add
role="presentation" to layout tables with the following addition to
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextUtils.renderLayoutTableAttributes():
if (CoreRenderer.isScreenReaderMode(arc))
{
ResponseWriter writer = context.getResponseWriter();
writer.writeAttribute("datatable", "0", null);
--> writer.writeAttribute("role", "presentation", null); <--
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1696) acc (screen reader mode) layout
tables should include role="presentation"
Posted by "Matt Cooper (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Cooper updated TRINIDAD-1696:
----------------------------------
Resolution: Fixed
Fix Version/s: 1.2.14-core
Status: Resolved (was: Patch Available)
> acc (screen reader mode) layout tables should include role="presentation"
> -------------------------------------------------------------------------
>
> Key: TRINIDAD-1696
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1696
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.12-core
> Environment: all
> Reporter: Dave Robinson
> Assignee: Matt Cooper
> Priority: Minor
> Fix For: 1.2.14-core
>
> Attachments: TRINIDAD-1696 for trinidad 1.2.12.1.patch, TRINIDAD-1696 for trinidad 1.2.12.2.patch, TRINIDAD-1696 for trinidad trunk.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> When using trh:tableLayout in our page to layout some UI components, it gives
> warning during Accessibility testing:
> "WARNING - This layout Table could be confused for a data table by Screen
> Readers"
> From the html perspective, this warning can be fixed by setting
> role="presentation"
> on the html table element.
> We can add
> role="presentation" to layout tables with the following addition to
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextUtils.renderLayoutTableAttributes():
> if (CoreRenderer.isScreenReaderMode(arc))
> {
> ResponseWriter writer = context.getResponseWriter();
> writer.writeAttribute("datatable", "0", null);
> --> writer.writeAttribute("role", "presentation", null); <--
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1696) acc (screen reader mode) layout
tables should include role="presentation"
Posted by "Dave Robinson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Robinson updated TRINIDAD-1696:
------------------------------------
Status: Patch Available (was: Open)
> acc (screen reader mode) layout tables should include role="presentation"
> -------------------------------------------------------------------------
>
> Key: TRINIDAD-1696
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1696
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.12-core
> Environment: all
> Reporter: Dave Robinson
> Priority: Minor
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> When using trh:tableLayout in our page to layout some UI components, it gives
> warning during Accessibility testing:
> "WARNING - This layout Table could be confused for a data table by Screen
> Readers"
> From the html perspective, this warning can be fixed by setting
> role="presentation"
> on the html table element.
> We can add
> role="presentation" to layout tables with the following addition to
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputTextUtils.renderLayoutTableAttributes():
> if (CoreRenderer.isScreenReaderMode(arc))
> {
> ResponseWriter writer = context.getResponseWriter();
> writer.writeAttribute("datatable", "0", null);
> --> writer.writeAttribute("role", "presentation", null); <--
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.