You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/12 09:15:56 UTC
[GitHub] [spark] ulysses-you opened a new pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
ulysses-you opened a new pull request #31817:
URL: https://github.com/apache/spark/pull/31817
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Skip `Long.MaxValue` sizeInBytes stats during generate tree string.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In cast explian mode, we might get such explain string if the table is external and we have not stats. A simple example:
```
== Optimized Logical Plan ==
GlobalLimit 21, Statistics(sizeInBytes=1008.0 B, rowCount=21)
+- LocalLimit 21, Statistics(sizeInBytes=12.0 EiB)
+- Project [cast(c1#52 as string) AS c1#259, pt#53], Statistics(sizeInBytes=12.0 EiB)
+- Relation default.pt1[c1#52,pt#53] parquet, Statistics(sizeInBytes=8.0 EiB)
```
The reason is we use the `Long.MaxValue` as the stats with conf `spark.sql.defaultSizeInBytes`. It would be better to hide the default stat.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, make cost plan clearly.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797517154
@maropu yeah, good point, seems this approach just handle the leaf node which use the `spark.sql.defaultSizeInBytes` directly. But we need to care about other node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797399044
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40582/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797534210
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136007/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797858608
Seems there is no easy way to distinguish if the stats of current plan is visit based on the default sizeInBytes.
Another thought, maybe we can make the default sizeInBytes as `Option` instead of `Long.MaxValue` since there is no meaning to estimate stats based on the `Long.MaxValue` for most plan. And for some independent e.g. `Limit`, we could leave it.
I'm worried that might introduce many changes but just for such minor issue, close this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797534210
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136007/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797533061
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797394445
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135998/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797394445
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135998/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you closed pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #31817:
URL: https://github.com/apache/spark/pull/31817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797430250
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40582/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797512693
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797417191
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40582/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797492826
> == Optimized Logical Plan ==
GlobalLimit 21, Statistics(sizeInBytes=1008.0 B, rowCount=21)
+- LocalLimit 21, Statistics(sizeInBytes=12.0 EiB)
+- Project [cast(c1#52 as string) AS c1#259, pt#53], Statistics(sizeInBytes=12.0 EiB)
+- Relation default.pt1[c1#52,pt#53] parquet, Statistics(sizeInBytes=8.0 EiB)
`8.0 EiB` is hidden and `12 EiB` is not in the example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797533061
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31817: [SPARK-34725][SQL] Do not show Statistics(sizeInBytes=8.0 EiB) if we don't have valid stats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31817:
URL: https://github.com/apache/spark/pull/31817#issuecomment-797430250
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40582/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org