You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2025/11/18 11:51:04 UTC
[PR] [1.9.x] Name mappers cleanup [maven-resolver]
cstamas opened a new pull request, #1674:
URL: https://github.com/apache/maven-resolver/pull/1674
Cleanup name mappers usage and introduce new, more selective mapper GAECV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [1.9.x] Name mappers cleanup and new GAECV mapper [maven-resolver]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #1674:
URL: https://github.com/apache/maven-resolver/pull/1674#discussion_r2537986947
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/NameMappers.java:
##########
@@ -46,11 +64,44 @@ public static NameMapper staticNameMapper() {
}
public static NameMapper gavNameMapper() {
- return GAVNameMapper.gav();
+ return gavNameMapper(false);
+ }
+
+ public static NameMapper gavNameMapper(boolean fileSystemFriendly) {
Review Comment:
Missing `@since`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [1.9.x] Name mappers cleanup and new GAECV mapper [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1674:
URL: https://github.com/apache/maven-resolver/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [1.9.x] Name mappers cleanup and new GAECV mapper [maven-resolver]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1674:
URL: https://github.com/apache/maven-resolver/pull/1674#issuecomment-3547451119
> Cleanup name mappers usage and introduce new, more selective mapper GAECV.
>
> Changes:
>
> * introduce GAECV next to existing GAV name mapper.
> * make default GAECV
So we're diminishing lock contentions at the cost of acquiring more locks, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [1.9.x] Name mappers cleanup and new GAECV mapper [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1674:
URL: https://github.com/apache/maven-resolver/pull/1674#discussion_r2537994196
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/NameMappers.java:
##########
@@ -46,11 +64,44 @@ public static NameMapper staticNameMapper() {
}
public static NameMapper gavNameMapper() {
- return GAVNameMapper.gav();
+ return gavNameMapper(false);
+ }
+
+ public static NameMapper gavNameMapper(boolean fileSystemFriendly) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [1.9.x] Name mappers cleanup and new GAECV mapper [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1674:
URL: https://github.com/apache/maven-resolver/pull/1674#issuecomment-3547461102
> So we're diminishing lock contentions at the cost of acquiring more locks, right ?
Yes, client code of SyncContext still asks for same number of artifacts/metadata, but existing GAV name mapper coalesced them into GAV-only. But IMO it is worth it (unless we see something down the road; but then we just need to swap back the default one in adapter), as so far we locked "whole GAV" even if some classifier was needed, hurting badly concurrency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org