[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34400: [SPARK-36975][SQL] Correct the hive client calls‘s metrics in HiveClientImpl

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #34400:
URL: https://github.com/apache/spark/pull/34400#discussion_r737663522



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -259,7 +272,7 @@ private[client] class Shim_v0_12 extends Shim with Logging {
     msc
   }
 
-  override def getMSC(hive: Hive): IMetaStoreClient = {
+  override def getMSC(hive: Hive): IMetaStoreClient = withHiveCall {

Review comment:
       > does this send an RPC request?
   
   Since the only call on this have a client call, now should be clear




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org