You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/31 05:14:33 UTC

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #18218: [feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools

Technoboy- commented on code in PR #18218:
URL: https://github.com/apache/pulsar/pull/18218#discussion_r1009035786


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -1965,6 +1965,32 @@ protected void internalSetOffloadThreshold(long newThreshold) {
         }
     }
 
+    protected void internalSetOffloadThresholdInSeconds(long newThreshold) {

Review Comment:
   We should make this method to be async.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org