[GitHub] [arrow] romainfrancois commented on a change in pull request #7645: ARROW-8374 [R]: Table to vector of DictonaryType will error when Arrays don't have the same Dictionary per array

[GitBox <gi...@apache.org>]

romainfrancois commented on a change in pull request #7645:
URL: https://github.com/apache/arrow/pull/7645#discussion_r452154972



##########
File path: r/src/array_to_vector.cpp
##########
@@ -180,7 +183,7 @@ class Converter_Date32 : public Converter_SimpleArray<REALSXP> {
   }
 
   Status Ingest_some_nulls(SEXP data, const std::shared_ptr<arrow::Array>& array,
-                           R_xlen_t start, R_xlen_t n) const {
+                           R_xlen_t start, R_xlen_t n, size_t array_index) const {

Review comment:
       Because this only gets called from `Converter::Ingest_some_nulls()` so they all need to have the same interface. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org