[GitHub] drill issue #971: Drill-5834 Add Networking Functions

[cgivre <gi...@git.apache.org>]

Github user cgivre commented on the issue:

    https://github.com/apache/drill/pull/971
  
    Thanks!  I’ll resubmit this weekend using commons-validator
    
    
    > On Oct 11, 2017, at 11:26, Arina Ielchiieva <no...@github.com> wrote:
    > 
    > @arina-ielchiieva commented on this pull request.
    > 
    > In exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java <https://github.com/apache/drill/pull/971#discussion_r144047807>:
    > 
    > > +        }
    > +
    > +        out.value = result;
    > +      }
    > +    }
    > +  }
    > +
    > +  /**
    > +   * Returns true if the input string is a valid IP address
    > +   */
    > +  @FunctionTemplate(
    > +    name = "is_valid_IP",
    > +    scope = FunctionTemplate.FunctionScope.SIMPLE,
    > +    nulls = FunctionTemplate.NullHandling.NULL_IF_NULL
    > +  )
    > +  public static class IsValidIPFunction implements DrillSimpleFunc {
    > We exclude commons-logging because Drill uses logback for logging.
    > Excluding it from commons-validator should work perfectly fine (I have tried).
    > 
    >     <dependency>
    >       <groupId>commons-validator</groupId>
    >       <artifactId>commons-validator</artifactId>
    >       <version>1.4.0</version>
    >       <exclusions>
    >       <exclusion>
    >         <groupId>commons-logging</groupId>
    >         <artifactId>commons-logging</artifactId>
    >       </exclusion>
    >       </exclusions>
    >     </dependency>
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub <https://github.com/apache/drill/pull/971#discussion_r144047807>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFQfvnNVrqNWjpBNlz61SDhXT9nhnJxcks5srN4ngaJpZM4Pseni>.
    > 
    



---