You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/19 04:55:43 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #37896: [SPARK-40482][SQL] Revert `SPARK-24544 Print actual failure cause when look up function failed`

cloud-fan commented on code in PR #37896:
URL: https://github.com/apache/spark/pull/37896#discussion_r973862236


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -1588,10 +1587,9 @@ class SessionCatalog(
       TableFunctionRegistry.builtin.functionExists(name)
   }
 
-  protected[sql] def failFunctionLookup(

Review Comment:
   We used to pass the `cause` parameter before, when looking up builtin functions from Hive. The code path is gone now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org