You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/29 14:03:27 UTC
[GitHub] [pulsar] MarvinCai opened a new pull request, #17336: [feat] Add option to clean up all metadata.
MarvinCai opened a new pull request, #17336:
URL: https://github.com/apache/pulsar/pull/17336
Fixes https://github.com/apache/pulsar/issues/15450
### Motivation
Currently after calling `delete-cluster-metadata` there're still metadata remain under `/admin` and `/pulsar` path which could cause trouble if zookeeper is shared between different Pulsar cluster.
### Modifications
Add option to clean up topics policies and other policies and function related metadata under `/admin` and` /pulsar` when tearing down cluster.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
doc auto generated
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #17336: [feat] Add option to clean up all metadata.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on PR #17336:
URL: https://github.com/apache/pulsar/pull/17336#issuecomment-1231069334
@eolivelli Yes, we could, but that's gonna the default behavior, which might break any existing users' operation that depends on this default behavior(even it's not the desired behavior), also if a configuration meta store(global zk) is used then nuking all topic policies could also break other geo replication clusters that also using this meta store. So I'm thinking adding it as optional first. WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17336: [feat] Add option to clean up all metadata.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17336:
URL: https://github.com/apache/pulsar/pull/17336#issuecomment-1284820848
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org