[GitHub] [hadoop] sodonnel commented on pull request #2533: HDFS-15719. [Hadoop 3] Both NameNodes can crash simultaneously due to the short JN socket timeout

[GitBox <gi...@apache.org>]

sodonnel commented on pull request #2533:
URL: https://github.com/apache/hadoop/pull/2533#issuecomment-746036162


   Changing this idle timeout seems like a good idea to me. As @ayushtkn mentioned, I think you have accidentally included "Bump Jetty Version" too in this PR.
   
   Do we also need to update the various *-site.xml files? I see this parameter mentioned here, and always as 1 second:
   
   ```
   $ grep -R -A1 "hadoop.http.idle_timeout.ms" *
   hadoop-common-project/hadoop-common/src/main/resources/core-default.xml:    <name>hadoop.http.idle_timeout.ms</name>
   hadoop-common-project/hadoop-common/src/main/resources/core-default.xml-    <value>1000</value>
   --
   hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java:      "hadoop.http.idle_timeout.ms";
   hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java-  public static final int HTTP_IDLE_TIMEOUT_MS_DEFAULT = 10000;
   --
   hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java:      "hadoop.http.idle_timeout.ms";
   hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java-  public static final int HADOOP_HTTP_IDLE_TIMEOUT_MS_DEFAULT = 1000;
   --
   hadoop-common-project/hadoop-kms/src/main/resources/kms-default.xml:    <name>hadoop.http.idle_timeout.ms</name>
   hadoop-common-project/hadoop-kms/src/main/resources/kms-default.xml-    <value>1000</value>
   --
   hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/resources/httpfs-default.xml:    <name>hadoop.http.idle_timeout.ms</name>
   hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/resources/httpfs-default.xml-    <value>1000</value>
   ```
   
   Note it is also mentioned on CommonConfigurationKeysPublic.java and HttpServer2.java as well as the *-site.xml file. Its a bit confusing for it to be mentioned in so many places.
   
   Should HttpServer2 reference the constant and default in CommonConfigurationKeysPublic instead?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org