You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 19:11:18 UTC
[GitHub] [flink] TisonKun opened a new pull request #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
TisonKun opened a new pull request #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261
Straightforward code clean up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11261: [hotfix][streaming]
Clean up redundant & dead code about StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-592684125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed504c69ae44a27c482bfbf82679ab40fc638d1d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-592684125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151079491",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed504c69ae44a27c482bfbf82679ab40fc638d1d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151079491) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-592684125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151079491",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151684714",
"triggerID" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"triggerType" : "PUSH"
}, {
"hash" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5896",
"triggerID" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f93243324fed1d67e4d17360e80bb91d6aa1726 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151684714) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5896)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-592684125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151079491",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151684714",
"triggerID" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"triggerType" : "PUSH"
}, {
"hash" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5896",
"triggerID" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f93243324fed1d67e4d17360e80bb91d6aa1726 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151684714) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5896)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#discussion_r387682415
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
##########
@@ -213,20 +210,6 @@ private static Configuration getEffectiveConfiguration(
return effectiveConfiguration;
}
- @Override
- public JobExecutionResult execute(StreamGraph streamGraph) throws Exception {
- try {
- return super.execute(streamGraph);
- }
- catch (ProgramInvocationException e) {
- throw e;
- }
- catch (Exception e) {
- String term = e.getMessage() == null ? "." : (": " + e.getMessage());
- throw new ProgramInvocationException("The program execution failed" + term, e);
Review comment:
I think this change is not as simple as it might look like. By changing the thrown exception we are effectively changing public API here. Such a change should definitely not happen as part of a hotfix commit!
Admittedly, the signature says that we are throwing an `Exception` instead of a `ProgramInvocationException` but until now the `RemoteStreamEnvironment` contract that it only throws `ProgramInvocationExceptions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun closed pull request #11261: [hotfix][streaming]
Clean up redundant & dead code about StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
TisonKun closed pull request #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#discussion_r385873950
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
##########
@@ -213,20 +210,6 @@ private static Configuration getEffectiveConfiguration(
return effectiveConfiguration;
}
- @Override
- public JobExecutionResult execute(StreamGraph streamGraph) throws Exception {
- try {
- return super.execute(streamGraph);
- }
- catch (ProgramInvocationException e) {
- throw e;
- }
- catch (Exception e) {
- String term = e.getMessage() == null ? "." : (": " + e.getMessage());
- throw new ProgramInvocationException("The program execution failed" + term, e);
Review comment:
Let's say that FLINK-15090 requires remove usage of `ProgramInvocationException` which belongs to `flink-client` which will then be no longer a dependency of `flink-streaming`. I don't think user should rely on `ProgramInvocationException` which itself doesn't keep consistency(always thrown) among environments. It would be just for display and no harm we use the `super` implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-592684125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151079491",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed504c69ae44a27c482bfbf82679ab40fc638d1d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151079491) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #11261: [hotfix][streaming]
Clean up redundant & dead code about StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-594590219
superseded by #11311 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-592684125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151079491",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151684714",
"triggerID" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"triggerType" : "PUSH"
}, {
"hash" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5896",
"triggerID" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed504c69ae44a27c482bfbf82679ab40fc638d1d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151079491) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759)
* 1f93243324fed1d67e4d17360e80bb91d6aa1726 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151684714) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5896)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #11261: [hotfix][streaming]
Clean up redundant & dead code about StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-594581711
@tillrohrmann Yes you're right that this change deserves a JIRA ticket and wider discussion. Sorry for misusing hotfix. Will convert it into a formal JIRA.
For the change itself it is from the discussion with @aljoscha that we want to reverse the dependency from flink-streaming-java to flink-client. It happened that the actually `Exception` is always `ProgramInvocationExceptions` which is a unfortunate accident. Since flink-client depends on flink-java we never throw such Exception(directly, possibly by reflect, though) from with batch codepath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11261:
[hotfix][streaming] Clean up redundant & dead code about
StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-592684125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151079491",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759",
"triggerID" : "ed504c69ae44a27c482bfbf82679ab40fc638d1d",
"triggerType" : "PUSH"
}, {
"hash" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f93243324fed1d67e4d17360e80bb91d6aa1726",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed504c69ae44a27c482bfbf82679ab40fc638d1d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151079491) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5759)
* 1f93243324fed1d67e4d17360e80bb91d6aa1726 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11261: [hotfix][streaming]
Clean up redundant & dead code about StreamExecutionEnvironment
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11261: [hotfix][streaming] Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#issuecomment-592744460
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ed504c69ae44a27c482bfbf82679ab40fc638d1d (Fri Feb 28 21:48:33 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services