You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/10/08 07:49:30 UTC
[jira] Created: (HBASE-3091) Fix TestKillingServersFromMaster in
TRUNK; it just hangs since new master went in
Fix TestKillingServersFromMaster in TRUNK; it just hangs since new master went in
---------------------------------------------------------------------------------
Key: HBASE-3091
URL: https://issues.apache.org/jira/browse/HBASE-3091
Project: HBase
Issue Type: Bug
Reporter: stack
Priority: Critical
Fix For: 0.90.0
This test depends on mechanisms much changed after new master went in so it just hangs; its not getting the confirmations it used expect. This issue is about recasting the test -- because what it tests is useful (just reading the test I found bug in new master) -- so need to get it going again. Marking critiical for 0.90.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-3091) Fix TestKillingServersFromMaster in
TRUNK; it just hangs since new master went in
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-3091.
--------------------------
Resolution: Fixed
Assignee: stack
Committed the test rename and reenable.
> Fix TestKillingServersFromMaster in TRUNK; it just hangs since new master went in
> ---------------------------------------------------------------------------------
>
> Key: HBASE-3091
> URL: https://issues.apache.org/jira/browse/HBASE-3091
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: 3091.txt
>
>
> This test depends on mechanisms much changed after new master went in so it just hangs; its not getting the confirmations it used expect. This issue is about recasting the test -- because what it tests is useful (just reading the test I found bug in new master) -- so need to get it going again. Marking critiical for 0.90.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3091) Fix TestKillingServersFromMaster in
TRUNK; it just hangs since new master went in
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919164#action_12919164 ]
stack commented on HBASE-3091:
------------------------------
For now I renamed src/test/java/org/apache/hadoop/hbase/master/TestKillingServersFromMaster.java as src/test/java/org/apache/hadoop/hbase/master/BROKE_FIX_TestKillingServersFromMaster.java
> Fix TestKillingServersFromMaster in TRUNK; it just hangs since new master went in
> ---------------------------------------------------------------------------------
>
> Key: HBASE-3091
> URL: https://issues.apache.org/jira/browse/HBASE-3091
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Critical
> Fix For: 0.90.0
>
>
> This test depends on mechanisms much changed after new master went in so it just hangs; its not getting the confirmations it used expect. This issue is about recasting the test -- because what it tests is useful (just reading the test I found bug in new master) -- so need to get it going again. Marking critiical for 0.90.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-3091) Fix TestKillingServersFromMaster in
TRUNK; it just hangs since new master went in
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3091:
-------------------------
Attachment: 3091.txt
Reenable of test. 1 of the 3 didn't make sense any more. Reenabling found a few issues around shutdown.... small stuff but still....
{code}
A src/test/java/org/apache/hadoop/hbase/master/TestKillingServersFromMaster.java
Rename of tests file we'd put aside. Also removed @Ignore from two of the
three tests this class used contain. I left @Ignore on 3rd test because
behavior has changed regards what happens when an 'unknown server'. I added
note to the test explaining why its left @Ignored
D src/test/java/org/apache/hadoop/hbase/master/BROKE_FIX_TestKillingServersFromMaster.java
Rename ... removed BROKE_FIX_ prefix.
M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
I saw us go into wait on root after server hosting root went down. Added
a timeout waiting on root. Check stop if we timeout w/o finding root.
Also, we weren't doing right thing if we got a YouAreDeadException. Fix.
M src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
Remove unused imports.
M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
Don't assign if server is stopped.
M src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
Don't process server shutdown if stopped.
M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
Add new isRootAvailable.
{code}
> Fix TestKillingServersFromMaster in TRUNK; it just hangs since new master went in
> ---------------------------------------------------------------------------------
>
> Key: HBASE-3091
> URL: https://issues.apache.org/jira/browse/HBASE-3091
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: 3091.txt
>
>
> This test depends on mechanisms much changed after new master went in so it just hangs; its not getting the confirmations it used expect. This issue is about recasting the test -- because what it tests is useful (just reading the test I found bug in new master) -- so need to get it going again. Marking critiical for 0.90.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.