[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #845: Add persistent IDs to partition fields

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #845: Add persistent IDs to partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r403186492
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/PartitionField.java
 ##########
 @@ -28,11 +28,13 @@
  */
 public class PartitionField implements Serializable {
   private final int sourceId;
+  private final int fieldId;
   private final String name;
   private final Transform<?, ?> transform;
 
-  PartitionField(int sourceId, String name, Transform<?, ?> transform) {
+  PartitionField(int sourceId, int fieldId, String name, Transform<?, ?> transform) {
     this.sourceId = sourceId;
+    this.fieldId = fieldId;
 
 Review comment:
   I don't think so. That is a convention that we use, but not strictly required by the spec.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org