[GitHub] [accumulo] lbschanno commented on a change in pull request #1374: WIP: Give ThriftTransportPool higher concurrent granularity

[GitBox <gi...@apache.org>]

lbschanno commented on a change in pull request #1374: WIP: Give ThriftTransportPool higher concurrent granularity
URL: https://github.com/apache/accumulo/pull/1374#discussion_r347720712
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java
 ##########
 @@ -67,7 +70,8 @@ public CachedConnection reserveAny() {
     }
   }
 
-  private Map<ThriftTransportKey,CachedConnections> cache = new HashMap<>();
+  private ConcurrentHashMap<ThriftTransportKey,Lock> locks = new ConcurrentHashMap<>();
 
 Review comment:
   I created something similar to this, but called `ConnectionPool`. I also added on additional methods both for `ConnectionPool` and `CachedConnections` in an attempt to make the code more concise overall.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services