You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/08 11:19:45 UTC

[GitHub] [flink] rkhachatryan edited a comment on pull request #13551: [FLINK-19520][configuration] Add randomization of checkpoint config.

rkhachatryan edited a comment on pull request #13551:
URL: https://github.com/apache/flink/pull/13551#issuecomment-740558364


   Assuming that the priorities are:
   1. increase the probability of detecting an error
   1. in particular, before merging - i.e. by committer either locally or remotely
   1. improve the usability
   
   The "MiniClusterResource" approach compared to the "properties" approach:
   - is worse for (1) because a smaller subset of tests is randomized
   - is better for (2) as you mention above
   - is worse for (3) because it's not easy to see what else tests fail with a certain configuration (when I already know that some fail)
   
   It also seems more complex (though I haven't thought through how to set the property globally).
   
   Additionally, I can imagine a "mandatory" set of combinations that must pass (in several runs) in order to release or be sure to merge. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org