You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by nickwallen <gi...@git.apache.org> on 2016/03/15 18:16:59 UTC
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
GitHub user nickwallen opened a pull request:
https://github.com/apache/incubator-metron/pull/46
METRON-69 EC2 Volume Enhancements
### Changes
- The EC2 volume sizes are now configurable
- The root volume is only expanded if needed.
### Validation
- [x] Positive and negative tests on live EC2 cluster.
- [x] License Check
- [x] Integration Tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/incubator-metron METRON-69
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit b59dd61e334d38e32cb6a8fed3072dca3ca119de
Author: Nick Allen <ni...@nickallen.org>
Date: 2016-03-15T15:12:52Z
METRON-69 The root volume is only expanded if necessary.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/46#issuecomment-197601920
I think the gap was that since we still have some work to do on idempoentence in the scripts, I mistakenly believed that no one would run these twice and expect to be happy with the result. It that holds (and potentially is documented somewhere) I'm good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/46#issuecomment-196965967
@dlyle65535 - Please take a gander
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/46#issuecomment-198380636
+1 as is. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/46#issuecomment-197425916
Overall looks good. I'll run it up. Originally, I only intended this to run once at first provisioning. You may want to consider enforcing that. I wouldn't move a partition end on a system after initial buildout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/46#issuecomment-197928924
No, not at all. Just don't want to introduce more places where it breaks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/46#issuecomment-197587133
Yes, this is a gap, but one that did already exist. At the very least this change is not making things worse.
Personally I would not be too concerned about this. if conditions ever exist for the 'expand-volume' logic to fire when it shouldn't then there are likely larger problems in the environment. The kind of 'larger' problems that might cause someone to just shoot the node in the head and start over anyways. I could be wrong though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: METRON-69 EC2 Volume Enhancements
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/46#issuecomment-197856007
Are you saying that we should not merge this PR until everything is completely idempotent? Totally open to a -1 if you think there is a better way that we should do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---