You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2016/07/11 08:39:16 UTC

[GitHub] brooklyn-server pull request #246: Fix adding multiple RendererHints for per...

GitHub user grkvlt opened a pull request:

    https://github.com/apache/brooklyn-server/pull/246

    Fix adding multiple RendererHints for percentage enricher

    Stops long stream of `WARN` log messages when using `PercentageEnricher` on a sensor that already has a `RendererHint` applied

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grkvlt/brooklyn-server multiple-hints-percentage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit acd7ad0dd7299cba9ba784c4ac3ee776bb673cd8
Author: Andrew Donald Kennedy <an...@cloudsoftcorp.com>
Date:   2016-07-11T08:31:52Z

    Fix adding multiple RendererHints for percentage enricher

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #246: Fix adding multiple RendererHints for per...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/246


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #246: Fix adding multiple RendererHints for percentage...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/246
  
    Test failure is unrelated - `RebindJmxFeedTest.testJmxFeedIsPersistedWithPreCreatedJmxHelper` fails with "java.rmi.server.ExportException: Port already in use: 40124". We should look at using port 0, so it chooses any free port, rather than us finding a free port and then telling it to use that port.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #246: Fix adding multiple RendererHints for percentage...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/246
  
    LGTM; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---