You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2012/11/14 23:00:13 UTC

[jira] [Created] (MYFACES-3641) ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId) should not throw exception if no associate VDL can be found

Leonardo Uribe created MYFACES-3641:
---------------------------------------

             Summary: ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId) should not throw exception if no associate VDL can be found
                 Key: MYFACES-3641
                 URL: https://issues.apache.org/jira/browse/MYFACES-3641
             Project: MyFaces Core
          Issue Type: Bug
            Reporter: Leonardo Uribe


This exception is thrown from ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId):

javax.faces.FacesException: Cannot find a valid PDL for view id /hxome.view.xml
        org.apache.myfaces.view.ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(ViewDeclarationLanguageFactoryImpl.java:93)
        org.apache.myfaces.application.ViewHandlerImpl.getViewDeclarationLanguage(ViewHandlerImpl.java:179)
        org.apache.myfaces.shared.application.DefaultViewHandlerSupport.checkResourceExists(DefaultViewHandlerSupport.java:546)
        org.apache.myfaces.shared.application.DefaultViewHandlerSupport.handleSuffixMapping(DefaultViewHandlerSupport.java:484)
        org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateViewId(DefaultViewHandlerSupport.java:114)
        org.apache.myfaces.application.ViewHandlerImpl.deriveLogicalViewId(ViewHandlerImpl.java:118)
        org.apache.myfaces.lifecycle.RestoreViewExecutor.execute(RestoreViewExecutor.java:157)
        org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:170)
        org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:117)
        javax.faces.webapp.FacesServlet.service(FacesServlet.java:197)

Instead throw an exception it return null, which indicates that the viewId has not associate VDL. Other algorithms in myfaces has already expect that, like DefaultViewHandlerSupport.checkResourceExists()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (MYFACES-3641) ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId) should not throw exception if no associate VDL can be found

Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg reopened MYFACES-3641:
------------------------------------

      Assignee: Mark Struberg  (was: Leonardo Uribe)

Leo, it's just plain **** to rely on a hash for a key which must be ensured to be unique!

I gonna open a VOTE about principal design rules and in the meantime revert your commit
                
> ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId) should not throw exception if no associate VDL can be found
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3641
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3641
>             Project: MyFaces Core
>          Issue Type: Bug
>            Reporter: Leonardo Uribe
>            Assignee: Mark Struberg
>             Fix For: 2.0.16, 2.1.10
>
>
> This exception is thrown from ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId):
> javax.faces.FacesException: Cannot find a valid PDL for view id /hxome.view.xml
>         org.apache.myfaces.view.ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(ViewDeclarationLanguageFactoryImpl.java:93)
>         org.apache.myfaces.application.ViewHandlerImpl.getViewDeclarationLanguage(ViewHandlerImpl.java:179)
>         org.apache.myfaces.shared.application.DefaultViewHandlerSupport.checkResourceExists(DefaultViewHandlerSupport.java:546)
>         org.apache.myfaces.shared.application.DefaultViewHandlerSupport.handleSuffixMapping(DefaultViewHandlerSupport.java:484)
>         org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateViewId(DefaultViewHandlerSupport.java:114)
>         org.apache.myfaces.application.ViewHandlerImpl.deriveLogicalViewId(ViewHandlerImpl.java:118)
>         org.apache.myfaces.lifecycle.RestoreViewExecutor.execute(RestoreViewExecutor.java:157)
>         org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:170)
>         org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:117)
>         javax.faces.webapp.FacesServlet.service(FacesServlet.java:197)
> Instead throw an exception it return null, which indicates that the viewId has not associate VDL. Other algorithms in myfaces has already expect that, like DefaultViewHandlerSupport.checkResourceExists()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (MYFACES-3641) ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId) should not throw exception if no associate VDL can be found

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-3641.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.10
                   2.0.16
         Assignee: Leonardo Uribe
    
> ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId) should not throw exception if no associate VDL can be found
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3641
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3641
>             Project: MyFaces Core
>          Issue Type: Bug
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.16, 2.1.10
>
>
> This exception is thrown from ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId):
> javax.faces.FacesException: Cannot find a valid PDL for view id /hxome.view.xml
>         org.apache.myfaces.view.ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(ViewDeclarationLanguageFactoryImpl.java:93)
>         org.apache.myfaces.application.ViewHandlerImpl.getViewDeclarationLanguage(ViewHandlerImpl.java:179)
>         org.apache.myfaces.shared.application.DefaultViewHandlerSupport.checkResourceExists(DefaultViewHandlerSupport.java:546)
>         org.apache.myfaces.shared.application.DefaultViewHandlerSupport.handleSuffixMapping(DefaultViewHandlerSupport.java:484)
>         org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateViewId(DefaultViewHandlerSupport.java:114)
>         org.apache.myfaces.application.ViewHandlerImpl.deriveLogicalViewId(ViewHandlerImpl.java:118)
>         org.apache.myfaces.lifecycle.RestoreViewExecutor.execute(RestoreViewExecutor.java:157)
>         org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:170)
>         org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:117)
>         javax.faces.webapp.FacesServlet.service(FacesServlet.java:197)
> Instead throw an exception it return null, which indicates that the viewId has not associate VDL. Other algorithms in myfaces has already expect that, like DefaultViewHandlerSupport.checkResourceExists()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira