You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "shunping (via GitHub)" <gi...@apache.org> on 2024/01/02 18:40:01 UTC

[I] [Bug]: Fix lints in timers.go [beam]

shunping opened a new issue, #29895:
URL: https://github.com/apache/beam/issues/29895

   ### What happened?
   
   1. In `func TimersEventTime_Bounded()`, the function name should not contain "_". https://github.com/apache/beam/blob/783c72a6dcebee2e60fb065f6890be6f8de4d48d/sdks/go/test/integration/primitives/timers.go#L142. 
      Please make sure to change the comment at https://github.com/apache/beam/blob/783c72a6dcebee2e60fb065f6890be6f8de4d48d/sdks/go/test/integration/primitives/timers.go#L141
   2. In `func TimersEventTime_Unbounded()`, the function name should not contain "_". https://github.com/apache/beam/blob/783c72a6dcebee2e60fb065f6890be6f8de4d48d/sdks/go/test/integration/primitives/timers.go#L147.
     Please make sure to change the comment at
   https://github.com/apache/beam/blob/783c72a6dcebee2e60fb065f6890be6f8de4d48d/sdks/go/test/integration/primitives/timers.go#L146. Notice that the original comment is incorrectly referencing the "Bounded" function.
   
   
   ### Issue Priority
   
   Priority: 3 (minor)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [ ] Component: Java SDK
   - [X] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam YAML
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Fix lints in timers.go [beam]

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck closed issue #29895: [Bug]: Fix lints in timers.go
URL: https://github.com/apache/beam/issues/29895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Fix lints in timers.go [beam]

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on issue #29895:
URL: https://github.com/apache/beam/issues/29895#issuecomment-1874444785

   Google's slightly more stringent lint policy strikes again. This is under active work, so I'll fix it in my next PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org