[GitHub] [ignite] Diana-Iakovleva commented on a change in pull request #6839: IGNITE-11815: replace GridTestUtils.retryAssert with GridTestUtils.waitForCondition

[GitBox <gi...@apache.org>]

Diana-Iakovleva commented on a change in pull request #6839: IGNITE-11815: replace GridTestUtils.retryAssert with GridTestUtils.waitForCondition
URL: https://github.com/apache/ignite/pull/6839#discussion_r322763805
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java
 ##########
 @@ -1701,6 +1701,9 @@ private static boolean areCompatible(Object[] objs, Class[] types) {
      * {@code assertion} closure will be executed {@code retries} + 1 times and
      * thread will spend approximately {@code retries} * {@code retryInterval} sleeping.
      *
+     * Please consider GridTestUtils#waitForCondition(GridAbsPredicate, long)
+     * to make logs clearer and to avoid possible false positive results.
+     *
 
 Review comment:
   Done. I've made another method, which in general do the same but it's exception-free to make tests clearer, is it acceptable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services