You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by huzaifafaruqui <hu...@gmail.com> on 2017/03/05 17:07:26 UTC
[allura:tickets] #7811 Coloring of long lines in diffs stops too early
coloring of diff can be made dynamic based on length but I am not sure if this looks good.
Attachments:
- [Screenshot from 2017-03-05 22-35-14.png](https://forge-allura.apache.org/p/allura/tickets/_discuss/thread/14dab7f9/cad1/attachment/Screenshot%20from%202017-03-05%2022-35-14.png) (8.0 kB; image/png)
---
** [tickets:#7811] Coloring of long lines in diffs stops too early**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Jan 05, 2015 04:04 AM UTC by Sworddragon
**Last Updated:** Tue Feb 10, 2015 05:57 AM UTC
**Owner:** nobody
**Attachments:**
- [2015_01_04_23_45_48.png](https://forge-allura.apache.org/p/allura/tickets/7811/attachment/2015_01_04_23_45_48.png) (70.9 kB; image/png)
As the screenshot shows the coloring in a diff stops too early if a line is too long.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #7811 Coloring of long lines in diffs stops too early
Posted by Dave Brondsema <da...@brondsema.net>.
Good point, it might actually be helpful, even if its not a common approach. I think most I've seen color the whole line, or color the text (which would prevent the possibility of doing syntax highlighting with the text color). Maybe a few bigger examples would help us see how good it is or not.
---
** [tickets:#7811] Coloring of long lines in diffs stops too early**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Jan 05, 2015 04:04 AM UTC by Sworddragon
**Last Updated:** Sun Mar 05, 2017 05:07 PM UTC
**Owner:** nobody
**Attachments:**
- [2015_01_04_23_45_48.png](https://forge-allura.apache.org/p/allura/tickets/7811/attachment/2015_01_04_23_45_48.png) (70.9 kB; image/png)
As the screenshot shows the coloring in a diff stops too early if a line is too long.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #7811 Coloring of long lines in diffs stops too early
Posted by Sworddragon <sw...@aol.com>.
It might look the best but dynamic length coloring would have the advantage that it is obvious when a line ends which might be from a developers point of view more useful.
---
** [tickets:#7811] Coloring of long lines in diffs stops too early**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Jan 05, 2015 04:04 AM UTC by Sworddragon
**Last Updated:** Sun Mar 05, 2017 05:07 PM UTC
**Owner:** nobody
**Attachments:**
- [2015_01_04_23_45_48.png](https://forge-allura.apache.org/p/allura/tickets/7811/attachment/2015_01_04_23_45_48.png) (70.9 kB; image/png)
As the screenshot shows the coloring in a diff stops too early if a line is too long.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #7811 Coloring of long lines in diffs stops too early
Posted by Dave Brondsema <da...@brondsema.net>.
Yeah that doesn't look very good to me either. I think coloring the whole row would be best.
---
** [tickets:#7811] Coloring of long lines in diffs stops too early**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Jan 05, 2015 04:04 AM UTC by Sworddragon
**Last Updated:** Sun Mar 05, 2017 05:07 PM UTC
**Owner:** nobody
**Attachments:**
- [2015_01_04_23_45_48.png](https://forge-allura.apache.org/p/allura/tickets/7811/attachment/2015_01_04_23_45_48.png) (70.9 kB; image/png)
As the screenshot shows the coloring in a diff stops too early if a line is too long.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.