You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/28 23:06:52 UTC

[GitHub] [incubator-druid] gianm opened a new pull request #7567: SQL: Remove "useFallback" feature.

gianm opened a new pull request #7567: SQL: Remove "useFallback" feature.
URL: https://github.com/apache/incubator-druid/pull/7567
 
 
   This feature allows Calcite's Bindable interpreter to be bolted on
   top of Druid queries and table scans. I think it should be removed for
   a few reasons:
   
   1. It is not recommended for production anyway, because it generates
   unscalable query plans (e.g. it will plan a join into two table scans
   and then try to do the entire join in memory on the broker).
   2. It doesn't work with Druid-specific SQL functions, like TIME_FLOOR,
   REGEXP_EXTRACT, APPROX_COUNT_DISTINCT, etc.
   3. It makes the SQL planning code needlessly complicated.
   
   With SQL coming out of experimental status soon, it's a good opportunity
   to remove this feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org