You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/09/04 07:25:33 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4579: Misc fixes
for aggregation functions
codecov-io commented on issue #4579: Misc fixes for aggregation functions
URL: https://github.com/apache/incubator-pinot/pull/4579#issuecomment-527778243
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4579?src=pr&el=h1) Report
> Merging [#4579](https://codecov.io/gh/apache/incubator-pinot/pull/4579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f3aa4dbe5e67a016165210a6ec9c6b26454fc79d?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4579?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4579 +/- ##
============================================
- Coverage 64.42% 64.39% -0.03%
Complexity 32 32
============================================
Files 1072 1072
Lines 55638 55633 -5
Branches 8112 8112
============================================
- Hits 35842 35823 -19
- Misses 17142 17163 +21
+ Partials 2654 2647 -7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4579?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../data/aggregator/PercentileEstValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvUGVyY2VudGlsZUVzdFZhbHVlQWdncmVnYXRvci5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ator/query/DictionaryBasedAggregationOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9EaWN0aW9uYXJ5QmFzZWRBZ2dyZWdhdGlvbk9wZXJhdG9yLmphdmE=) | `89.28% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pinot/core/data/aggregator/AvgValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvQXZnVmFsdWVBZ2dyZWdhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `69.09% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...startree/executor/StarTreeAggregationExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9leGVjdXRvci9TdGFyVHJlZUFnZ3JlZ2F0aW9uRXhlY3V0b3IuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/core/startree/v2/store/StarTreeLoaderUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZUxvYWRlclV0aWxzLmphdmE=) | `93.65% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ta/aggregator/DistinctCountHLLValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvRGlzdGluY3RDb3VudEhMTFZhbHVlQWdncmVnYXRvci5qYXZh) | `85.71% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/pinot/core/plan/TransformPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL1RyYW5zZm9ybVBsYW5Ob2RlLmphdmE=) | `87.75% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../query/aggregation/DefaultAggregationExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9EZWZhdWx0QWdncmVnYXRpb25FeGVjdXRvci5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ore/startree/v2/builder/BaseSingleTreeBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9idWlsZGVyL0Jhc2VTaW5nbGVUcmVlQnVpbGRlci5qYXZh) | `95.26% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [64 more](https://codecov.io/gh/apache/incubator-pinot/pull/4579/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4579?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4579?src=pr&el=footer). Last update [f3aa4db...6088ad0](https://codecov.io/gh/apache/incubator-pinot/pull/4579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org