You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2024/07/17 04:17:49 UTC

(impala) 01/03: IMPALA-13227: test_spilling_hash_join should be marked for serial execution

This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 3de8c2ab9c755b1adfc35ea2176a2ac193899ca6
Author: Zoltan Borok-Nagy <bo...@cloudera.com>
AuthorDate: Mon Jul 15 19:49:13 2024 +0200

    IMPALA-13227: test_spilling_hash_join should be marked for serial execution
    
    test_spilling_hash_join consumes too much resources and parallel
    tests can fail because of it. We should mark it for serial execution.
    
    Testing:
     * had a green exhaustive run, and we also now that before
       test_spilling_hash_join was added, the exhaustive runs
       were much stable
    
    Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
    Reviewed-on: http://gerrit.cloudera.org:8080/21589
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_join_queries.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/query_test/test_join_queries.py b/tests/query_test/test_join_queries.py
index 10939ab4f..90105af7c 100644
--- a/tests/query_test/test_join_queries.py
+++ b/tests/query_test/test_join_queries.py
@@ -214,8 +214,11 @@ class TestSpillingHashJoin(ImpalaTestSuite):
     if cls.exploration_strategy() != 'exhaustive':
       cls.ImpalaTestMatrix.add_constraint(lambda v: False)
     cls.ImpalaTestMatrix.add_constraint(
-      lambda v: v.get_value('table_format').file_format == 'parquet')
+        lambda v: v.get_value('table_format').file_format == 'parquet')
+    cls.ImpalaTestMatrix.add_constraint(lambda v:
+        v.get_value('exec_option')['disable_codegen'] is False)
 
+  @pytest.mark.execute_serially
   def test_spilling_hash_join(self, vector, unique_database):
     """Regression test for IMPALA-13138. It loads a few large tables and runs a complex
     query that spills during JOIN build that crashed Impala before IMPALA-13138."""