You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/24 13:48:00 UTC
[jira] [Work logged] (BEAM-14166) Improvements to RowWithGetter
[ https://issues.apache.org/jira/browse/BEAM-14166?focusedWorklogId=747236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747236 ]
ASF GitHub Bot logged work on BEAM-14166:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/22 13:47
Start Date: 24/Mar/22 13:47
Worklog Time Spent: 10m
Work Description: mosche opened a new pull request #17172:
URL: https://github.com/apache/beam/pull/17172
Various improvements to getValue(fieldIdx) in RowWithGetters mentioned [here](https://issues.apache.org/jira/browse/BEAM-14166#discussion_r833602836)
- Minimize memory overhead of cache using either a index lookup (array) or a single hash map if number of fields exceeds the initial hashmap capacity
- The cache should be checked before calling a getter to avoid any potentially unnecessary conversion in the getter itself.
[Nested rows](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L111) should be cached, otherwise the cache of such nested rows can't be leveraged.
- Handling of collections / maps / iterables can be significantly improved by simply skipping the transform in all cases where getValue for members is the [identity transform](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L142).
As mentioned in [BEAM-14166](https://issues.apache.org/jira/browse/BEAM-14166#discussion_r833602836), it would also be possible to (optionally) pre-calculate the required cache size and indices and store this as metadata in schema & field options. Though, this is probably a bit more controversial... If you'd like to evaluate this idea further I can do a prototype for Java Field/Bean schemas.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 747236)
Remaining Estimate: 0h
Time Spent: 10m
> Improvements to RowWithGetter
> -----------------------------
>
> Key: BEAM-14166
> URL: https://issues.apache.org/jira/browse/BEAM-14166
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Various improvements to getValue(fieldIdx) in RowWithGetters mentioned [here|[https://github.com/apache/beam/pull/16947#discussion_r833602836]:]
> * Minimize memory overhead of cache using either a index lookup (array) or a single hash map if number of fields exceeds the initial hashmap capacity
> * The cache should be checked before calling a getter to avoid any potentially unnecessary conversion in the getter itself.
> * [Nested rows|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L111] should be cached, otherwise the cache of such nested rows can't be leveraged.
> * Handling of collections / maps / iterables can be significantly improved by simply skipping the transform in all cases where {{getValue}} for members is the [identity transform|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L142].
--
This message was sent by Atlassian Jira
(v8.20.1#820001)