You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Vincenzo Gianferrari Pini <vi...@praxis.it> on 2003/06/09 01:46:45 UTC

[no virus] [PATCH]HasAttachment was ignoring some attachments and reporting others inexistent

Noel,

here is another patch:

--------
HasAttachment was ignoring some attachments and reporting others inexistent: if there was a message with no inline text and an attachment, was erroneously not matching; if the message had inline text with HTML format and no attachments, was erroneously matching.
--------

It could be further refined: for instance, a pkcs7 inline text signed message with no
attachment was and is reported as having it (in my case the public key is an attachment). But at this point, what is an attachment?

I added also an overall catch of any throwable, being consistent with a previous patch to AttachmentFileNameIs and with what I have been saying in the "Separating internal errors from addressing errors in config.xml" postings in this list, but I think there should be some consensus on the approach to exception handling.

Good night,

Vincenzo