You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/13 13:11:41 UTC

[jira] [Commented] (ARTEMIS-1112) EmbeddedJMS.start() doesn't return if shared-store master starts as backup server

    [ https://issues.apache.org/jira/browse/ARTEMIS-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967566#comment-15967566 ] 

ASF GitHub Bot commented on ARTEMIS-1112:
-----------------------------------------

GitHub user bgutjahr opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1204

    ARTEMIS-1112: don't block live activation if another live server is running

    Instead of going directly into backup mode within the shared-store
    live activation, we just change the HA-policy to slave and return
    to the caller - ActiveMQServerImpl.internalStart().
    The caller will then handle the backup activation as usual
    in a separate thread, such that EmbeddedJMS.start() can return.
    
    	modified:   artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedStoreLiveActivation.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bgutjahr/activemq-artemis master-as-backup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1204
    
----
commit b3e39e3c2038de9c94251525a21f216d82cd0958
Author: Bernd Gutjahr <be...@hpe.com>
Date:   2017-04-13T13:01:36Z

    ARTEMIS-1112: don't block live activation if another live server is running
    
    Instead of going directly into backup mode within the shared-store
    live activation, we just change the HA-policy to slave and return
    to the caller - ActiveMQServerImpl.internalStart().
    The caller will then handle the backup activation as usual
    in a separate thread, such that EmbeddedJMS.start() can return.
    
    	modified:   artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedStoreLiveActivation.java

----


> EmbeddedJMS.start() doesn't return if shared-store master starts as backup server
> ---------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1112
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1112
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.5.4, 2.0.0
>            Reporter: Bernd Gutjahr
>            Priority: Minor
>
> EmbeddedServer.start() doesn't return when a share-store master server has been configured, but at startup another server is already running as live server (i.e. another previously started master).
> In that case, this server becomes a backup server for the currently running live server. The start() method hangs until the currently running live server stops and this server actually becomes the new live server.
> This is inconsistent with starting a server as slave server, where the start method returns and doesn't wait until the slave took over as live server.
> It also blocks the application that called EmbeddedServer.start() to proceed it's normal operation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)