You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/06/17 20:58:07 UTC

Review Request 22691: Only report cpu.stat values if CFS quota is enabled.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22691/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-1479
    https://issues.apache.org/jira/browse/MESOS-1479


Repository: mesos-git


Description
-------

The values aren't meaningful and cpu.stat may not even be available (which causes usage() to fail).


Diffs
-----

  src/slave/containerizer/isolators/cgroups/cpushare.cpp ca1b421c0e01b5be8728e458bc895c6272aac7f5 

Diff: https://reviews.apache.org/r/22691/diff/


Testing
-------

./bin/mesos-tests.sh --gtest_filter="CpuIsolatorTest*"


Thanks,

Ian Downes


Re: Review Request 22691: Only report cpu.stat values if CFS quota is enabled.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22691/#review45972
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On June 17, 2014, 6:58 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22691/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 6:58 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1479
>     https://issues.apache.org/jira/browse/MESOS-1479
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The values aren't meaningful and cpu.stat may not even be available (which causes usage() to fail).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp ca1b421c0e01b5be8728e458bc895c6272aac7f5 
> 
> Diff: https://reviews.apache.org/r/22691/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter="CpuIsolatorTest*"
> 
> 
> Thanks,
> 
> Ian Downes
> 
>