Re: svn commit: r1124709 - /subversion/trunk/subversion/libsvn_client/cleanup.c

[Daniel Shahaf <d....@daniel.shahaf.name>]

hwright@apache.org wrote on Thu, May 19, 2011 at 12:29:16 -0000:
> Author: hwright
> Date: Thu May 19 12:29:16 2011
> New Revision: 1124709
> 
> URL: http://svn.apache.org/viewvc?rev=1124709&view=rev
> Log:
> Fix the upgrade tests.  (The only reason they are failing is because 'u' is
> late in the alphabet.)
> 

Huh??  What do you mean by that parentheical?

If it's just "I didn't wait for 'make check' to finish", could you edit
the log to say that?  I was quite puzzled how run_tests.py's order could
have caused the failure.

> * subversion/libsvn_client/cleanup.c
>   (svn_client_upgrade): Use an abspath when calling the new propget API.
> 
> Modified:
>     subversion/trunk/subversion/libsvn_client/cleanup.c
> 
> Modified: subversion/trunk/subversion/libsvn_client/cleanup.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/cleanup.c?rev=1124709&r1=1124708&r2=1124709&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_client/cleanup.c (original)
> +++ subversion/trunk/subversion/libsvn_client/cleanup.c Thu May 19 12:29:16 2011
> @@ -143,8 +143,8 @@ svn_client_upgrade(const char *path,
>       upgrade to avoid that errors in the externals causes the wc upgrade to
>       fail. Thanks to caching the performance penalty of walking the wc a
>       second time shouldn't be too severe */
> -  SVN_ERR(svn_client_propget4(&externals, SVN_PROP_EXTERNALS, path, &rev,
> -                              &rev, NULL, svn_depth_infinity, NULL, ctx,
> +  SVN_ERR(svn_client_propget4(&externals, SVN_PROP_EXTERNALS, local_abspath,
> +                              &rev, &rev, NULL, svn_depth_infinity, NULL, ctx,
>                                scratch_pool, scratch_pool));
>  
>    iterpool = svn_pool_create(scratch_pool);
> 
>