You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2013/08/14 03:03:29 UTC
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 1:03 a.m.)
Review request for oozie.
Changes
-------
WIP patch - still fleshing out why unit test with Dates fails.
Bugs: OOZIE-1476
https://issues.apache.org/jira/browse/OOZIE-1476
Repository: oozie
Description
-------
See JIRA OOZIE-1476
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1513230
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1513230
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1513230
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1513230
trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1513230
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1513230
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSmallObjJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1513230
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1513230
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1513230
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1513230
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1513230
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1513230
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1513230
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1513230
Diff: https://reviews.apache.org/r/13097/diff/
Testing
-------
added unit tests
Thanks,
Mona Chitnis
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Aug. 14, 2013, 7:06 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java, line 122
> > <https://reviews.apache.org/r/13097/diff/3/?file=341217#file341217line122>
> >
> >
> > instead of db query, just do KillXCommand (coordAction.getExternalId), no?
can do. I was using the workflow job's start-time for the subsequent job notification constructor. But event here can make do with coordAction.getCreatedTime()
> On Aug. 14, 2013, 7:06 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java, line 177
> > <https://reviews.apache.org/r/13097/diff/3/?file=341217#file341217line177>
> >
> > this is fishy, doesn't seem right. This means if user issues two kill commands, one might be removed as duplicate.
right. thinking of appending the 'scope' string to key
> On Aug. 14, 2013, 7:06 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java, line 111
> > <https://reviews.apache.org/r/13097/diff/3/?file=341217#file341217line111>
> >
> > Can we do this JPA query in loadState()?
> >
> > this query would bring all actions in 'TERMINALSTATE OR RUNNING'
> > It should bring all actions in 'NON-TERMINAL' state
Added separate JPA Executor
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/#review25170
-----------------------------------------------------------
On Aug. 14, 2013, 5:28 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13097/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 5:28 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1476
> https://issues.apache.org/jira/browse/OOZIE-1476
>
>
> Repository: oozie
>
>
> Description
> -------
>
> See JIRA OOZIE-1476
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1513230
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1513230
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1513230
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1513230
> trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1513230
> trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1513230
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1513230
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1513230
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1513230
> trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1513230
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1513230
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSmallObjJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1513230
> trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1513230
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1513230
> trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1513230
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1513230
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1513230
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1513230
>
> Diff: https://reviews.apache.org/r/13097/diff/
>
>
> Testing
> -------
>
> added unit tests
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/#review25170
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/13097/#comment49425>
Need a REST APi, change in oozie CLI and JAVA API. Also print the message in oozie help and update docs
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java
<https://reviews.apache.org/r/13097/#comment49436>
A suspended coord job should be allowed to have its actions killed.
We should have 'DONEWITHERROR' here.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java
<https://reviews.apache.org/r/13097/#comment49429>
Can we do this JPA query in loadState()?
this query would bring all actions in 'TERMINALSTATE OR RUNNING'
It should bring all actions in 'NON-TERMINAL' state
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java
<https://reviews.apache.org/r/13097/#comment49431>
this extra datastructures can be avoided if above query is changed.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java
<https://reviews.apache.org/r/13097/#comment49433>
instead of db query, just do KillXCommand (coordAction.getExternalId), no?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java
<https://reviews.apache.org/r/13097/#comment49432>
lets set pending to 0 (safe)
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java
<https://reviews.apache.org/r/13097/#comment49434>
this is fishy, doesn't seem right. This means if user issues two kill commands, one might be removed as duplicate.
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/13097/#comment49435>
Having it in else would never make it execute.
- Virag Kothari
On Aug. 14, 2013, 5:28 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13097/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 5:28 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1476
> https://issues.apache.org/jira/browse/OOZIE-1476
>
>
> Repository: oozie
>
>
> Description
> -------
>
> See JIRA OOZIE-1476
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1513230
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1513230
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1513230
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1513230
> trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1513230
> trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1513230
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1513230
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1513230
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1513230
> trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1513230
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1513230
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSmallObjJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1513230
> trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1513230
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1513230
> trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1513230
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1513230
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1513230
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1513230
>
> Diff: https://reviews.apache.org/r/13097/diff/
>
>
> Testing
> -------
>
> added unit tests
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Aug. 15, 2013, 4:51 a.m., Virag Kothari wrote:
> > Looks good..only few minor comments
> >
> > Twiki needs to be updated.
> > Have java doc for new classes
ah had forgotten to include twiki diff here
> On Aug. 15, 2013, 4:51 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java, line 150
> > <https://reviews.apache.org/r/13097/diff/4/?file=341467#file341467line150>
> >
> > remove this entirely, a user command shouldn't be filtered even though its the same...also remove from coordKill
good point. But users should be warned against not issuing repeated kill commands
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/#review25206
-----------------------------------------------------------
On Aug. 15, 2013, 2:19 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13097/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 2:19 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1476
> https://issues.apache.org/jira/browse/OOZIE-1476
>
>
> Repository: oozie
>
>
> Description
> -------
>
> See JIRA OOZIE-1476
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1514128
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1514128
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1514128
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1514128
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1514128
> trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1514128
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsByDatesForKillJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1514128
> trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1514128
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1514128
> trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1514128
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1514128
> trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1514128
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1514128
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1514128
>
> Diff: https://reviews.apache.org/r/13097/diff/
>
>
> Testing
> -------
>
> added unit tests
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/#review25206
-----------------------------------------------------------
Looks good..only few minor comments
Twiki needs to be updated.
Have java doc for new classes
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/13097/#comment49499>
correct the java doc
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java
<https://reviews.apache.org/r/13097/#comment49493>
remove this entirely, a user command shouldn't be filtered even though its the same...also remove from coordKill
- Virag Kothari
On Aug. 15, 2013, 2:19 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13097/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 2:19 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1476
> https://issues.apache.org/jira/browse/OOZIE-1476
>
>
> Repository: oozie
>
>
> Description
> -------
>
> See JIRA OOZIE-1476
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1514128
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1514128
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1514128
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1514128
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1514128
> trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1514128
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsByDatesForKillJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1514128
> trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1514128
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1514128
> trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1514128
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1514128
> trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1514128
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1514128
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1514128
>
> Diff: https://reviews.apache.org/r/13097/diff/
>
>
> Testing
> -------
>
> added unit tests
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/#review25219
-----------------------------------------------------------
Ship it!
Ship It!
- Virag Kothari
On Aug. 15, 2013, 6:20 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13097/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 6:20 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1476
> https://issues.apache.org/jira/browse/OOZIE-1476
>
>
> Repository: oozie
>
>
> Description
> -------
>
> See JIRA OOZIE-1476
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1514128
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1514128
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1514128
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1514128
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1514128
> trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1514128
> trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1514128
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsByDatesForKillJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1514128
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1514128
> trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1514128
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1514128
> trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1514128
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1514128
> trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1514128
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1514128
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1514128
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1514128
>
> Diff: https://reviews.apache.org/r/13097/diff/
>
>
> Testing
> -------
>
> added unit tests
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/
-----------------------------------------------------------
(Updated Aug. 15, 2013, 6:20 p.m.)
Review request for oozie.
Changes
-------
addressed final set of Virag's comments
Bugs: OOZIE-1476
https://issues.apache.org/jira/browse/OOZIE-1476
Repository: oozie
Description
-------
See JIRA OOZIE-1476
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1514128
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1514128
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1514128
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1514128
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1514128
trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1514128
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsByDatesForKillJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1514128
trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1514128
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1514128
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1514128
trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1514128
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1514128
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1514128
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1514128
trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1514128
trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1514128
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1514128
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1514128
Diff: https://reviews.apache.org/r/13097/diff/
Testing
-------
added unit tests
Thanks,
Mona Chitnis
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/
-----------------------------------------------------------
(Updated Aug. 15, 2013, 2:19 a.m.)
Review request for oozie.
Changes
-------
Addressed Review comments and added a bunch of client facing tests
Bugs: OOZIE-1476
https://issues.apache.org/jira/browse/OOZIE-1476
Repository: oozie
Description
-------
See JIRA OOZIE-1476
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1514128
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1514128
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1514128
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1514128
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1514128
trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1514128
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1514128
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsByDatesForKillJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1514128
trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1514128
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1514128
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1514128
trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1514128
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1514128
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1514128
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1514128
trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1514128
trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1514128
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1514128
Diff: https://reviews.apache.org/r/13097/diff/
Testing
-------
added unit tests
Thanks,
Mona Chitnis
Re: Review Request 13097: OOZIE-1476 Add ability to issue kill on
Coordinator Action directly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13097/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 5:28 p.m.)
Review request for oozie.
Changes
-------
Removing files irrelevant to JIRA, and some duplicate patches in r2
Bugs: OOZIE-1476
https://issues.apache.org/jira/browse/OOZIE-1476
Repository: oozie
Description
-------
See JIRA OOZIE-1476
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1513230
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1513230
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1513230
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1513230
trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1513230
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1513230
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1513230
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSmallObjJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1513230
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1513230
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1513230
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1513230
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1513230
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1513230
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1513230
Diff: https://reviews.apache.org/r/13097/diff/
Testing
-------
added unit tests
Thanks,
Mona Chitnis