Cleaning the warnings
---------------------
Key: DIRSERVER-1056
URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
Project: Directory ApacheDS
Issue Type: Task
Affects Versions: 1.5.1
Reporter: Emmanuel Lecharny
Priority: Critical
Fix For: 1.5.2
We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu updated DIRSERVER-1056:
-------------------------------------
Fix Version/s: (was: 1.5.3)
1.5.4
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.5.4
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524517 ]
Emmanuel Lecharny commented on DIRSERVER-1056:
----------------------------------------------
One hundred warnings has been removed. Some more in the next few days.
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Critical
> Fix For: 1.5.2
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-1056:
-----------------------------------------
Fix Version/s: (was: 1.5.2)
1.5.3
Postponed. This is a never ending story anyway ...
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.5.3
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-1056:
-----------------------------------------
Fix Version/s: (was: 1.5.9)
2.0.0-RC1
Affected to 2.0.0-RC1, we won't release a 1.5.9
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529039 ]
Emmanuel Lecharny commented on DIRSERVER-1056:
----------------------------------------------
129 warnings in sources, 115 in tests
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Critical
> Fix For: 1.5.2
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527153 ]
Emmanuel Lecharny commented on DIRSERVER-1056:
----------------------------------------------
Down to 187 warnings in sources, 331 in tests, and 1526 total (thanks to antlr generated code...)
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Critical
> Fix For: 1.5.2
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527880 ]
Emmanuel Lecharny commented on DIRSERVER-1056:
----------------------------------------------
144 remaining warnings in sources, 257 in tests.
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Critical
> Fix For: 1.5.2
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny reassigned DIRSERVER-1056:
--------------------------------------------
Assignee: Emmanuel Lecharny
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Critical
> Fix For: 1.5.2
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu updated DIRSERVER-1056:
-------------------------------------
Fix Version/s: (was: 1.5.4)
1.5.9
review can clean up phase
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.5.9
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626780#action_12626780 ]
Emmanuel Lecharny commented on DIRSERVER-1056:
----------------------------------------------
We have a clear lower number of warning : around 1280.
The cleaning can -and should- be done on the fly. I don't think we need to spend one week trying to fix all the warnings. usually, this is something I do when I'm tired, because removing a warning is a low intensity task, and don't need a lot of brain :)
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.5.9
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543368 ]
Emmanuel Lecharny commented on DIRSERVER-1056:
----------------------------------------------
After having changed to Eclipse 3.3, and being a little bit more strict with warnings, I get now a total of 2010 warnings, out of which :
- 761 are in sources
- 1249 are in tests
This should not be scaring, as many of those warnings are related to lack of generic usage (for instance, we have _many_ places where we use Enumeration values = attr.getAll(); where we should use Enumeration<?> values = attr.getAll())
It's the same thing with Comparators.
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Critical
> Fix For: 1.5.2
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526733 ]
Emmanuel Lecharny commented on DIRSERVER-1056:
----------------------------------------------
Down to 265 warnings for source.
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Critical
> Fix For: 1.5.2
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/DIRSERVER-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu updated DIRSERVER-1056:
-------------------------------------
Priority: Minor (was: Critical)
> Cleaning the warnings
> ---------------------
>
> Key: DIRSERVER-1056
> URL: https://issues.apache.org/jira/browse/DIRSERVER-1056
> Project: Directory ApacheDS
> Issue Type: Task
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.5.2
>
>
> We have around 1900 warnings in the whole ADS project (excluding Studio). If we exclude antlr generated warnings, we still have around 1000 warnings.
> Again, if we exclude tests, we still have around 500 warnings. They are mainly Collections not being typed. We should remove those warnings asap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.