You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "b-phi (via GitHub)" <gi...@apache.org> on 2025/03/04 22:59:53 UTC
[PR] Expose ref_name parameter for table scans [iceberg-python]
b-phi opened a new pull request, #1765:
URL: https://github.com/apache/iceberg-python/pull/1765
I came across this issue which looks useful https://github.com/apache/iceberg-python/issues/1746. It turns out this feature is mostly already supported, but not directly exposed or documented. I reused [TableScan.use_ref](https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/__init__.py#L1496-L1502), assuming that has the desired error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Expose ref_name parameter for table scans [iceberg-python]
Posted by "b-phi (via GitHub)" <gi...@apache.org>.
b-phi closed pull request #1765: Expose ref_name parameter for table scans
URL: https://github.com/apache/iceberg-python/pull/1765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Expose ref_name parameter for table scans [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #1765:
URL: https://github.com/apache/iceberg-python/pull/1765#discussion_r1980868016
##########
pyiceberg/table/__init__.py:
##########
@@ -965,6 +969,10 @@ def scan(
options=options,
limit=limit,
)
+ if ref_name is not None:
+ scan = scan.use_ref(ref_name)
Review Comment:
Why not add this to the `__init__` of `DataScan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Expose ref_name parameter for table scans [iceberg-python]
Posted by "b-phi (via GitHub)" <gi...@apache.org>.
b-phi commented on code in PR #1765:
URL: https://github.com/apache/iceberg-python/pull/1765#discussion_r1981389638
##########
pyiceberg/table/__init__.py:
##########
@@ -965,6 +969,10 @@ def scan(
options=options,
limit=limit,
)
+ if ref_name is not None:
+ scan = scan.use_ref(ref_name)
Review Comment:
@Fokko I've updated to pass ref_name to `__init__`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org