You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2023/01/09 20:32:33 UTC

[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #407: allow self-signed certs when downloading test files over https (#405)

stevedlawrence commented on code in PR #407:
URL: https://github.com/apache/daffodil-vscode/pull/407#discussion_r1065080833


##########
src/tests/runTest.ts:
##########
@@ -34,7 +49,7 @@ async function main() {
     // Passed to --extensionTestsPath
     const extensionTestsPath = path.resolve(__dirname, './suite/index')
 
-    const vscodeExecutablePath = await downloadAndUnzipVSCode('1.68.0')
+    const vscodeExecutablePath = await downloadAndUnzipVSCode('stable')

Review Comment:
   Understood. Do we want to pin this to a particular version and periodically update it when we want to test with and support a newer version of VS Code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org