You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CrazyHZM (GitHub)" <gi...@apache.org> on 2019/03/22 03:09:26 UTC

[GitHub] [incubator-dubbo] CrazyHZM opened pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

## What is the purpose of the change
Merge dubbo-serialization-avro into incubator-dubbo #3708

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
There is no need to depend avro here.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
Fixed.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
It is fixed.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] tswstarplanet commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.
You can delete the line "<?xml version="1.0" encoding="UTF-8"?>"

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=h1) Report
> Merging [#3717](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/fca31c45f47da0dbc1cf0a85ad5d87b2384a5c36?src=pr&el=desc) will **decrease** coverage by `0.61%`.
> The diff coverage is `84.37%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3717      +/-   ##
============================================
- Coverage     63.57%   62.95%   -0.62%     
  Complexity       71       71              
============================================
  Files           704      728      +24     
  Lines         31063    32970    +1907     
  Branches       5037     5278     +241     
============================================
+ Hits          19747    20756    +1009     
- Misses         9039     9832     +793     
- Partials       2277     2382     +105
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dubbo/common/serialize/avro/AvroSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvU2VyaWFsaXphdGlvbi5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [.../dubbo/common/serialize/avro/AvroObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvT2JqZWN0T3V0cHV0LmphdmE=) | `81.81% <81.81%> (ø)` | `0 <0> (?)` | |
| [...e/dubbo/common/serialize/avro/AvroObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvT2JqZWN0SW5wdXQuamF2YQ==) | `84.61% <84.61%> (ø)` | `0 <0> (?)` | |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `60.72% <0%> (-0.37%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `73.46% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...bbo/rpc/protocol/thrift/io/InputStreamWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvaW8vSW5wdXRTdHJlYW1XcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...o/rpc/protocol/thrift/DubboClassNameGenerator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvRHViYm9DbGFzc05hbWVHZW5lcmF0b3IuamF2YQ==) | `100% <0%> (ø)` | `0% <0%> (?)` | |
| [.../java/org/apache/dubbo/common/json/JSONWriter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9KU09OV3JpdGVyLmphdmE=) | `58.94% <0%> (ø)` | `0% <0%> (?)` | |
| ... and [25 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=footer). Last update [fca31c4...8aec7fd](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] tswstarplanet commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.
You can delete the line "xml version="1.0" encoding="UTF-8""

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 closed pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
[ pull request closed by ralf0131 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Hi, since 2.7.1 has been released, could you update it to 2.7.2-SNAPSHOT?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=h1) Report
> Merging [#3717](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/fb5d96de60716a0ea7fbd5eb41731b4d67e3a803?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `84.37%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3717      +/-   ##
============================================
+ Coverage     63.62%   63.63%   +0.01%     
  Complexity       71       71              
============================================
  Files           704      707       +3     
  Lines         31065    31129      +64     
  Branches       5037     5037              
============================================
+ Hits          19764    19808      +44     
- Misses         9032     9045      +13     
- Partials       2269     2276       +7
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dubbo/common/serialize/avro/AvroSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvU2VyaWFsaXphdGlvbi5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [.../dubbo/common/serialize/avro/AvroObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvT2JqZWN0T3V0cHV0LmphdmE=) | `81.81% <81.81%> (ø)` | `0 <0> (?)` | |
| [...e/dubbo/common/serialize/avro/AvroObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvT2JqZWN0SW5wdXQuamF2YQ==) | `84.61% <84.61%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-10.87%)` | `0% <0%> (ø)` | |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | `0% <0%> (ø)` | |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `73.46% <0%> (-2.73%)` | `0% <0%> (ø)` | |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `59.84% <0%> (-2.37%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `46.87% <0%> (-1.05%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `66.98% <0%> (-0.95%)` | `0% <0%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=footer). Last update [fb5d96d...371fc6c](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
No need to add it here.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
> You can delete the line "xml version="1.0" encoding="UTF-8""


I tried to do this, but I can't solve it.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
@ralf0131 
Can you help me see where the license is wrong?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
completed.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Fixed.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=h1) Report
> Merging [#3717](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/fca31c45f47da0dbc1cf0a85ad5d87b2384a5c36?src=pr&el=desc) will **decrease** coverage by `0.64%`.
> The diff coverage is `84.37%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3717      +/-   ##
============================================
- Coverage     63.57%   62.92%   -0.65%     
  Complexity       71       71              
============================================
  Files           704      728      +24     
  Lines         31063    32970    +1907     
  Branches       5037     5278     +241     
============================================
+ Hits          19747    20746     +999     
- Misses         9039     9839     +800     
- Partials       2277     2385     +108
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dubbo/common/serialize/avro/AvroSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvU2VyaWFsaXphdGlvbi5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [.../dubbo/common/serialize/avro/AvroObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvT2JqZWN0T3V0cHV0LmphdmE=) | `81.81% <81.81%> (ø)` | `0 <0> (?)` | |
| [...e/dubbo/common/serialize/avro/AvroObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvT2JqZWN0SW5wdXQuamF2YQ==) | `84.61% <84.61%> (ø)` | `0 <0> (?)` | |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `60.72% <0%> (-0.37%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `73.46% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...bbo/rpc/protocol/thrift/io/InputStreamWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvaW8vSW5wdXRTdHJlYW1XcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...o/rpc/protocol/thrift/DubboClassNameGenerator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvRHViYm9DbGFzc05hbWVHZW5lcmF0b3IuamF2YQ==) | `100% <0%> (ø)` | `0% <0%> (?)` | |
| [.../java/org/apache/dubbo/common/json/JSONWriter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9KU09OV3JpdGVyLmphdmE=) | `58.94% <0%> (ø)` | `0% <0%> (?)` | |
| ... and [24 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=footer). Last update [fca31c4...8aec7fd](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
You can run the UT locally and check the output to see what is the problem. For example: /home/travis/build/apache/incubator-dubbo/dubbo-serialization/dubbo-serialization-avro/target/rat.txt

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
Fixed.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=h1) Report
> Merging [#3717](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6e4ff91dfca4395a8d1b180f40f632e97acf779d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `84.37%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##             master   #3717      +/-   ##
===========================================
+ Coverage      63.6%   63.6%   +<.01%     
  Complexity       71      71              
===========================================
  Files           703     706       +3     
  Lines         31001   31065      +64     
  Branches       5022    5022              
===========================================
+ Hits          19718   19760      +42     
- Misses         9016    9031      +15     
- Partials       2267    2274       +7
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dubbo/common/serialize/avro/AvroSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvU2VyaWFsaXphdGlvbi5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [.../dubbo/common/serialize/avro/AvroObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvT2JqZWN0T3V0cHV0LmphdmE=) | `81.81% <81.81%> (ø)` | `0 <0> (?)` | |
| [...e/dubbo/common/serialize/avro/AvroObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWF2cm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvYXZyby9BdnJvT2JqZWN0SW5wdXQuamF2YQ==) | `84.61% <84.61%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-8.7%)` | `0% <0%> (ø)` | |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `75% <0%> (-6.25%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `66.98% <0%> (-0.95%)` | `0% <0%> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3717/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=footer). Last update [6e4ff91...86190f2](https://codecov.io/gh/apache/incubator-dubbo/pull/3717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kexianjun commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "kexianjun (GitHub)" <gi...@apache.org>.
encoderFactory also as above

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kexianjun commented on pull request #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "kexianjun (GitHub)" <gi...@apache.org>.
can we make decoderFactory as a static field?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3717: Merge dubbo-serialization-avro into incubator-dubbo #3708

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Hi, 

While I am reviewing this pull request, I feel more people should come in and take a look. Please request @beiwei30 to review as well.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3717 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org