You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/31 03:26:01 UTC
[GitHub] [rocketmq] xdkxlk opened a new pull request, #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor
xdkxlk opened a new pull request, #4940:
URL: https://github.com/apache/rocketmq/pull/4940
**Make sure set the target branch to `develop`**
## What is the purpose of the change
1. fix the concurrency problems when renew and ack/changeInvisibleTime at the same time
2. retry renew for a limited times when some error occurred
3. code refactor for ReceiptHandleProcessor
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor
Posted by GitBox <gi...@apache.org>.
xdkxlk commented on code in PR #4940:
URL: https://github.com/apache/rocketmq/pull/4940#discussion_r959215396
##########
proxy/src/main/java/org/apache/rocketmq/proxy/common/MessageReceiptHandle.java:
##########
@@ -27,24 +29,26 @@ public class MessageReceiptHandle {
private final String messageId;
private final long queueOffset;
private final String originalReceiptHandle;
- private final long timestamp;
private final int reconsumeTimes;
- private final long expectInvisibleTime;
- private String receiptHandle;
+ private final AtomicInteger renewRetryTimes = new AtomicInteger(0);
+ private long timestamp;
+ private long expectInvisibleTime;
+ private volatile String receiptHandle;
- public MessageReceiptHandle(String group, String topic, int queueId, String receiptHandle, String messageId,
- long queueOffset, int reconsumeTimes, long expectInvisibleTime) {
+ public MessageReceiptHandle(String group, String topic, int queueId, String receiptHandleStr, String messageId,
+ long queueOffset, int reconsumeTimes) {
+ ReceiptHandle receiptHandle = ReceiptHandle.decode(receiptHandleStr);
this.group = group;
this.topic = topic;
this.queueId = queueId;
- this.receiptHandle = receiptHandle;
- this.originalReceiptHandle = receiptHandle;
+ this.receiptHandle = receiptHandleStr;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lollipopjin commented on a diff in pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor
Posted by GitBox <gi...@apache.org>.
lollipopjin commented on code in PR #4940:
URL: https://github.com/apache/rocketmq/pull/4940#discussion_r959199154
##########
proxy/src/main/java/org/apache/rocketmq/proxy/common/MessageReceiptHandle.java:
##########
@@ -27,24 +29,26 @@ public class MessageReceiptHandle {
private final String messageId;
private final long queueOffset;
private final String originalReceiptHandle;
- private final long timestamp;
private final int reconsumeTimes;
- private final long expectInvisibleTime;
- private String receiptHandle;
+ private final AtomicInteger renewRetryTimes = new AtomicInteger(0);
+ private long timestamp;
+ private long expectInvisibleTime;
+ private volatile String receiptHandle;
- public MessageReceiptHandle(String group, String topic, int queueId, String receiptHandle, String messageId,
- long queueOffset, int reconsumeTimes, long expectInvisibleTime) {
+ public MessageReceiptHandle(String group, String topic, int queueId, String receiptHandleStr, String messageId,
+ long queueOffset, int reconsumeTimes) {
+ ReceiptHandle receiptHandle = ReceiptHandle.decode(receiptHandleStr);
this.group = group;
this.topic = topic;
this.queueId = queueId;
- this.receiptHandle = receiptHandle;
- this.originalReceiptHandle = receiptHandle;
+ this.receiptHandle = receiptHandleStr;
Review Comment:
Can here rename to receiptHandleStr for avoiding confusion with ReceiptHandle receiptHandle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #4940:
URL: https://github.com/apache/rocketmq/pull/4940#discussion_r959236200
##########
proxy/src/test/java/org/apache/rocketmq/proxy/common/ReceiptHandleGroupTest.java:
##########
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.proxy.common;
+
+import java.time.Duration;
+import java.util.Random;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Executors;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicReference;
+import org.apache.rocketmq.common.consumer.ReceiptHandle;
+import org.apache.rocketmq.common.message.MessageClientIDSetter;
+import org.apache.rocketmq.proxy.common.utils.FutureUtils;
+import org.apache.rocketmq.proxy.config.InitConfigAndLoggerTest;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.awaitility.Awaitility.await;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
+public class ReceiptHandleGroupTest extends InitConfigAndLoggerTest {
+
+ private static final String TOPIC = "topic";
+ private static final String GROUP = "group";
+ private ReceiptHandleGroup receiptHandleGroup;
+ private String msgID;
+ private final Random random = new Random();
+
+ @Before
+ public void before() throws Throwable {
+ super.before();
+ receiptHandleGroup = new ReceiptHandleGroup();
+ msgID = MessageClientIDSetter.createUniqID();
+ }
+
+ protected String createHandle() {
+ return ReceiptHandle.builder()
+ .startOffset(0L)
+ .retrieveTime(System.currentTimeMillis())
+ .invisibleTime(3000)
+ .reviveQueueId(1)
+ .topicType(ReceiptHandle.NORMAL_TOPIC)
+ .brokerName("brokerName")
+ .queueId(random.nextInt(10))
+ .offset(random.nextInt(10))
+ .commitLogOffset(0L)
+ .build().encode();
+ }
+
+ @Test
+ public void testRemoveWhenComputeIfPresent() throws Exception {
+ String handle1 = createHandle();
+ String handle2 = createHandle();
+ AtomicReference<MessageReceiptHandle> removeHandleRef = new AtomicReference<>();
+
+ receiptHandleGroup.put(msgID, handle1, createMessageReceiptHandle(handle1, msgID));
+ CountDownLatch latch = new CountDownLatch(1);
+ Thread removeThread = new Thread(() -> {
+ try {
+ latch.await();
+ removeHandleRef.set(receiptHandleGroup.remove(msgID, handle1));
+ } catch (Exception ignored) {
+ }
+ }, "removeThread");
+ Thread computeThread = new Thread(() -> {
+ try {
+ receiptHandleGroup.computeIfPresent(msgID, handle1, messageReceiptHandle -> {
+ try {
+ latch.await();
+ } catch (Exception ignored) {
+ }
+ messageReceiptHandle.updateReceiptHandle(handle2);
+ return FutureUtils.addExecutor(CompletableFuture.completedFuture(messageReceiptHandle), Executors.newCachedThreadPool());
+ });
+ } catch (Exception ignored) {
+ }
+ }, "computeThread");
+ removeThread.start();
+ computeThread.start();
+ Thread.sleep(10);
Review Comment:
Could we refine the sleep here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor
Posted by GitBox <gi...@apache.org>.
xdkxlk commented on code in PR #4940:
URL: https://github.com/apache/rocketmq/pull/4940#discussion_r959273452
##########
proxy/src/test/java/org/apache/rocketmq/proxy/common/ReceiptHandleGroupTest.java:
##########
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.proxy.common;
+
+import java.time.Duration;
+import java.util.Random;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Executors;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicReference;
+import org.apache.rocketmq.common.consumer.ReceiptHandle;
+import org.apache.rocketmq.common.message.MessageClientIDSetter;
+import org.apache.rocketmq.proxy.common.utils.FutureUtils;
+import org.apache.rocketmq.proxy.config.InitConfigAndLoggerTest;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.awaitility.Awaitility.await;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
+public class ReceiptHandleGroupTest extends InitConfigAndLoggerTest {
+
+ private static final String TOPIC = "topic";
+ private static final String GROUP = "group";
+ private ReceiptHandleGroup receiptHandleGroup;
+ private String msgID;
+ private final Random random = new Random();
+
+ @Before
+ public void before() throws Throwable {
+ super.before();
+ receiptHandleGroup = new ReceiptHandleGroup();
+ msgID = MessageClientIDSetter.createUniqID();
+ }
+
+ protected String createHandle() {
+ return ReceiptHandle.builder()
+ .startOffset(0L)
+ .retrieveTime(System.currentTimeMillis())
+ .invisibleTime(3000)
+ .reviveQueueId(1)
+ .topicType(ReceiptHandle.NORMAL_TOPIC)
+ .brokerName("brokerName")
+ .queueId(random.nextInt(10))
+ .offset(random.nextInt(10))
+ .commitLogOffset(0L)
+ .build().encode();
+ }
+
+ @Test
+ public void testRemoveWhenComputeIfPresent() throws Exception {
+ String handle1 = createHandle();
+ String handle2 = createHandle();
+ AtomicReference<MessageReceiptHandle> removeHandleRef = new AtomicReference<>();
+
+ receiptHandleGroup.put(msgID, handle1, createMessageReceiptHandle(handle1, msgID));
+ CountDownLatch latch = new CountDownLatch(1);
+ Thread removeThread = new Thread(() -> {
+ try {
+ latch.await();
+ removeHandleRef.set(receiptHandleGroup.remove(msgID, handle1));
+ } catch (Exception ignored) {
+ }
+ }, "removeThread");
+ Thread computeThread = new Thread(() -> {
+ try {
+ receiptHandleGroup.computeIfPresent(msgID, handle1, messageReceiptHandle -> {
+ try {
+ latch.await();
+ } catch (Exception ignored) {
+ }
+ messageReceiptHandle.updateReceiptHandle(handle2);
+ return FutureUtils.addExecutor(CompletableFuture.completedFuture(messageReceiptHandle), Executors.newCachedThreadPool());
+ });
+ } catch (Exception ignored) {
+ }
+ }, "computeThread");
+ removeThread.start();
+ computeThread.start();
+ Thread.sleep(10);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #4940:
URL: https://github.com/apache/rocketmq/pull/4940#issuecomment-1232426820
@xdkxlk thx for contributing, looks like another flaky test, could you create an issue for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #4940:
URL: https://github.com/apache/rocketmq/pull/4940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4940:
URL: https://github.com/apache/rocketmq/pull/4940#issuecomment-1232428917
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4940?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4940](https://codecov.io/gh/apache/rocketmq/pull/4940?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e25d0a2) into [develop](https://codecov.io/gh/apache/rocketmq/commit/64c18fb0dbb8d7e0e4af9edf49d04ab8dd64bccd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64c18fb) will **decrease** coverage by `0.11%`.
> The diff coverage is `68.31%`.
```diff
@@ Coverage Diff @@
## develop #4940 +/- ##
=============================================
- Coverage 43.29% 43.18% -0.12%
- Complexity 7688 7708 +20
=============================================
Files 991 995 +4
Lines 68781 69094 +313
Branches 9111 9149 +38
=============================================
+ Hits 29782 29836 +54
- Misses 35253 35513 +260
+ Partials 3746 3745 -1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...proxy/grpc/v2/consumer/ReceiveMessageActivity.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvY29uc3VtZXIvUmVjZWl2ZU1lc3NhZ2VBY3Rpdml0eS5qYXZh) | `73.91% <0.00%> (ø)` | |
| [.../org/apache/rocketmq/proxy/config/ProxyConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbmZpZy9Qcm94eUNvbmZpZy5qYXZh) | `48.96% <50.00%> (+0.05%)` | :arrow_up: |
| [...ache/rocketmq/proxy/common/ReceiptHandleGroup.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbW1vbi9SZWNlaXB0SGFuZGxlR3JvdXAuamF2YQ==) | `66.26% <60.00%> (+7.64%)` | :arrow_up: |
| [...cketmq/proxy/processor/ReceiptHandleProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3Byb2Nlc3Nvci9SZWNlaXB0SGFuZGxlUHJvY2Vzc29yLmphdmE=) | `69.94% <71.64%> (+12.79%)` | :arrow_up: |
| [...he/rocketmq/proxy/common/MessageReceiptHandle.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbW1vbi9NZXNzYWdlUmVjZWlwdEhhbmRsZS5qYXZh) | `75.43% <100.00%> (+28.63%)` | :arrow_up: |
| [...or/validator/DefaultTopicMessageTypeValidator.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3Byb2Nlc3Nvci92YWxpZGF0b3IvRGVmYXVsdFRvcGljTWVzc2FnZVR5cGVWYWxpZGF0b3IuamF2YQ==) | `40.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `39.77% <0.00%> (-9.95%)` | :arrow_down: |
| [...e/rocketmq/controller/impl/manager/BrokerInfo.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvQnJva2VySW5mby5qYXZh) | `78.94% <0.00%> (-9.29%)` | :arrow_down: |
| [...ocketmq/controller/impl/manager/SyncStateInfo.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvU3luY1N0YXRlSW5mby5qYXZh) | `83.33% <0.00%> (-7.58%)` | :arrow_down: |
| [...apache/rocketmq/store/queue/ConsumeQueueStore.java](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL0NvbnN1bWVRdWV1ZVN0b3JlLmphdmE=) | `53.41% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [78 more](https://codecov.io/gh/apache/rocketmq/pull/4940/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org