[GitHub] [airflow] potiuk commented on a diff in pull request #25094: Initial POC of GRPC Internal API

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #25094:
URL: https://github.com/apache/airflow/pull/25094#discussion_r922230726


##########
airflow/dag_processing/processor.py:
##########
@@ -642,11 +654,14 @@ def execute_callbacks(
 
     @provide_session
     def _execute_dag_callbacks(self, dagbag: DagBag, request: DagCallbackRequest, session: Session):
-        dag = dagbag.dags[request.dag_id]
-        dag_run = dag.get_dagrun(run_id=request.run_id, session=session)
-        dag.handle_callback(
-            dagrun=dag_run, success=not request.is_failure_callback, reason=request.msg, session=session
-        )
+        try:

Review Comment:
   Only needed to avoid errors for callbacks. I did not want to complicate it passing the "right" callbacks so "fake" callbacks I am passing now generate a lot of exceptions as dags/dag runs are not found,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org